Site Settings Desktop: Better support for chrome-extension scheme.

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 cr.define('site_list', function() {
   function registerTests() {
     suite('SiteList', function() {
       /**
        * A site list element created before each test.
@@ skipping 264 matching lines @@
               embeddingOrigin: '',
               incognito: true,
               origin: 'http://bar.com',
               setting: 'allow',
               source: 'preference',
             },
           ]
         }
       };
 
+      /**
+       * An example Javascript pref with a chrome-extension:// scheme.
+       * @type {SiteSettingsPref}
+       */
+      var prefsChromeExtension = {
+        exceptions: {
+          javascript: [
+            {
+              embeddingOrigin: '',
+              origin: 'chrome-extension://cfhgfbfpcbnnbibfphagcjmgjfjmojfa/',
+              setting: 'block',
+              source: 'preference',
+            },
+          ]
+        }
+      };
+
       // Import necessary html before running suite.
       suiteSetup(function() {
         CrSettingsPrefs.setInitialized();
         return PolymerTest.importHtml(
             'chrome://md-settings/site_settings/site_list.html');
       });
 
       suiteTeardown(function() {
         CrSettingsPrefs.resetForTesting();
       });
@@ skipping 466 matching lines @@
             settings.PermissionValues.ALLOW, prefs);
         return browserProxy.whenCalled('getExceptionList').then(function(
             contentType) {
           Polymer.dom.flush();
           var menuItems = getMenuItems(testElement.$.listContainer, 0);
           assertTrue(!!menuItems);
           MockInteractions.tap(menuItems[0]);
           return browserProxy.whenCalled('setCategoryPermissionForOrigin');
         });
       });
+
+      test('Chrome Extension scheme', function() {
+        setupCategory(settings.ContentSettingsTypes.JAVASCRIPT,
+            settings.PermissionValues.BLOCK, prefsChromeExtension);
+        return browserProxy.whenCalled('getExceptionList').then(function(
+            contentType) {
+          Polymer.dom.flush();
+          assertMenu(['Allow', 'Remove'], testElement);
+
+          var menuItems = getMenuItems(testElement.$.listContainer, 0);
+          assertTrue(!!menuItems);
+          MockInteractions.tap(menuItems[0]);  // Action: Allow.
+          return browserProxy.whenCalled('setCategoryPermissionForOrigin');
+        }).then(function(arguments) {

[dschuyler, 2016/09/28 19:13:40]

|arguments| is a special value, like |this|.
So arguments represents the whole argument list (normally).
In this case, a parameter with the same name is created
that is just the first argument rather than all the arguments.

If the intention is to use the build-in arguments, 
please remove the parameter "}).then(function() {".

If the intention is to pass an array to the function,
please change the name of the argument, maybe
"}).then(function(args) {".

Here's an example of showing what I mentioned above:
 
a=function() {console.log(arguments); }
a(2, 3)
--> [2, 3]
b=function(arguments) {console.log(arguments); }
b(2, 3)
--> 2

+          assertEquals('chrome-extension://cfhgfbfpcbnnbibfphagcjmgjfjmojfa/',
+              arguments[0]);
+          assertEquals('', arguments[1]);
+          assertEquals(settings.ContentSettingsTypes.JAVASCRIPT, arguments[2]);
+          assertEquals('allow', arguments[3]);
+        });
+      });
     });
   }
   return {
     registerTests: registerTests,
   };
 });