Site Settings Desktop: Better support for chrome-extension scheme.

Site Settings Desktop: Better support for chrome-extension scheme.

BUG=650552
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/09022f2c25367e6ed30af3cec48db61b94570524
Cr-Commit-Position: refs/heads/master@{#421803}

[Finnur, 2016-09-28 16:02:28]

Description was changed from

==========
Site Settings Desktop: Better support for chrome-extension scheme.

BUG=650552
==========

to

==========
Site Settings Desktop: Better support for chrome-extension scheme.

BUG=650552
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-09-28 16:02:32]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 16:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 16:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 16:51:39]

Dry run: This issue passed the CQ dry run.

[Finnur, 2016-09-28 17:39:28]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 17:39:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-09-28 17:42:25]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:34:54]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-28 19:13:40]

After the comment is addressed, LGTM.

https://codereview.chromium.org/2381583002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/site_list_tests.js (right):

https://codereview.chromium.org/2381583002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_list_tests.js:801:
}).then(function(arguments) {
|arguments| is a special value, like |this|.
So arguments represents the whole argument list (normally).
In this case, a parameter with the same name is created
that is just the first argument rather than all the arguments.

If the intention is to use the build-in arguments, 
please remove the parameter "}).then(function() {".

If the intention is to pass an array to the function,
please change the name of the argument, maybe
"}).then(function(args) {".

Here's an example of showing what I mentioned above:
 
a=function() {console.log(arguments); }
a(2, 3)
--> [2, 3]
b=function(arguments) {console.log(arguments); }
b(2, 3)
--> 2

[Finnur, 2016-09-29 11:13:31]

Oh, JavaScript... must you be so crazy. :)

Changed to |args|. Checking in.

[Finnur, 2016-09-29 11:13:36]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-09-29 11:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2381583002/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-09-29 11:13:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 12:11:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-29 12:12:59]

Description was changed from

==========
Site Settings Desktop: Better support for chrome-extension scheme.

BUG=650552
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Better support for chrome-extension scheme.

BUG=650552
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/09022f2c25367e6ed30af3cec48db61b94570524
Cr-Commit-Position: refs/heads/master@{#421803}
==========

[commit-bot: I haz the power, 2016-09-29 12:13:00]

Patchset 3 (id:??) landed as
https://crrev.com/09022f2c25367e6ed30af3cec48db61b94570524
Cr-Commit-Position: refs/heads/master@{#421803}