Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2381573002: Fix off-by-one issue in clustered snapshot implementation and api impl (Closed)

Created:
4 years, 2 months ago by kustermann
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix off-by-one issue in clustered snapshot implementation and api impl R=rmacnak@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/9195014572b016a916199b6ecf1565a5812fe977

Patch Set 1 #

Patch Set 2 : same in dart_api_impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/clustered_snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kustermann
4 years, 2 months ago (2016-09-28 15:52:38 UTC) #2
Cutch
+rmacnak
4 years, 2 months ago (2016-09-28 15:54:14 UTC) #4
rmacnak
LGTM
4 years, 2 months ago (2016-09-28 16:25:07 UTC) #5
Vyacheslav Egorov (Google)
lgtm
4 years, 2 months ago (2016-09-28 16:29:21 UTC) #6
kustermann
4 years, 2 months ago (2016-09-28 16:46:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9195014572b016a916199b6ecf1565a5812fe977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698