Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/Chromoting.java

Issue 2381543003: [Remoting Android] Separate help and feedback in navigation drawer (Closed)
Patch Set: Reviewer's Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/Chromoting.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
index 93e93646360baa0753c87bb8d53440b5b069b247..4bc7cc30b1104351784d56faf7e0a43f1a9a375a 100644
--- a/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
+++ b/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
@@ -33,11 +33,9 @@ import android.widget.Toast;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.Log;
-import org.chromium.chromoting.NavigationMenuAdapter.NavigationMenuItem;
import org.chromium.chromoting.accountswitcher.AccountSwitcher;
import org.chromium.chromoting.accountswitcher.AccountSwitcherFactory;
import org.chromium.chromoting.base.OAuthTokenFetcher;
-import org.chromium.chromoting.help.CreditsActivity;
import org.chromium.chromoting.help.HelpContext;
import org.chromium.chromoting.help.HelpSingleton;
import org.chromium.chromoting.jni.Client;
@@ -169,34 +167,6 @@ public class Chromoting extends AppCompatActivity implements ConnectionListener,
mProgressView.setVisibility(View.GONE);
}
- private ListView createNavigationMenu() {
- ListView navigationMenu = (ListView) getLayoutInflater()
- .inflate(R.layout.navigation_list, null);
-
- NavigationMenuItem helpItem = new NavigationMenuItem(R.menu.help_list_item,
- new Runnable() {
- @Override
- public void run() {
- HelpSingleton.getInstance().launchHelp(Chromoting.this,
- HelpContext.HOST_LIST);
- }
- });
-
- NavigationMenuItem creditsItem = new NavigationMenuItem(R.menu.credits_list_item,
- new Runnable() {
- @Override
- public void run() {
- startActivity(new Intent(Chromoting.this, CreditsActivity.class));
- }
- });
-
- NavigationMenuItem[] navigationMenuItems = { helpItem, creditsItem };
- NavigationMenuAdapter adapter = new NavigationMenuAdapter(this, navigationMenuItems);
- navigationMenu.setAdapter(adapter);
- navigationMenu.setOnItemClickListener(adapter);
- return navigationMenu;
- }
-
/**
* Called when the activity is first created. Loads the native library and requests an
* authentication token from the system.
@@ -268,7 +238,7 @@ public class Chromoting extends AppCompatActivity implements ConnectionListener,
getSupportActionBar().setHomeAsUpIndicator(menuIcon);
mAccountSwitcher = AccountSwitcherFactory.getInstance().createAccountSwitcher(this, this);
- mAccountSwitcher.setNavigation(createNavigationMenu());
+ mAccountSwitcher.setNavigation(NavigationMenuAdapter.createNavigationMenu(this));
LinearLayout navigationDrawer = (LinearLayout) findViewById(R.id.navigation_drawer);
mAccountSwitcher.setDrawer(navigationDrawer);
View switcherView = mAccountSwitcher.getView();

Powered by Google App Engine
This is Rietveld 408576698