[Remoting Android] Separate help and feedback in navigation drawer

remoting/android/java/src/org/chromium/chromoting/help/HelpActivity.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting.help;
 
 import android.app.Activity;
-import android.content.ComponentName;
 import android.content.Intent;
-import android.content.ServiceConnection;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.graphics.Bitmap;
 import android.net.Uri;
-import android.os.Binder;
 import android.os.Bundle;
-import android.os.IBinder;
-import android.os.Parcel;
-import android.os.RemoteException;
 import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.Toolbar;
 import android.text.TextUtils;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
 import android.webkit.WebView;
 import android.webkit.WebViewClient;
 
-import org.chromium.base.Log;
 import org.chromium.chromoting.ChromotingUtil;
 import org.chromium.chromoting.R;
 import org.chromium.ui.UiUtils;
 
 /**
  * The Activity for showing the Help screen.
  */
 public class HelpActivity extends AppCompatActivity {
-    private static final String TAG = "Chromoting";
-
     private static final String PLAY_STORE_URL = "market://details?id=";
 
-    private static final String FEEDBACK_PACKAGE = "com.google.android.gms";
-
-    private static final String FEEDBACK_CLASS =
-            "com.google.android.gms.feedback.LegacyBugReportService";
-
     /**
      * Maximum dimension for the screenshot to be sent to the Send Feedback handler.  This size
      * ensures the size of bitmap < 1MB, which is a requirement of the handler.
      */
     private static final int MAX_FEEDBACK_SCREENSHOT_DIMENSION = 600;
 
     /**
      * This global variable is used for passing the screenshot from the originating Activity to the
      * HelpActivity. There seems to be no better way of doing this.
      */
     private static Bitmap sScreenshot;
 
     /** WebView used to display help content. */
     private WebView mWebView;
 
-    /** Constant used to send the feedback parcel to the system feedback service. */
-    private static final int SEND_FEEDBACK_INFO = Binder.FIRST_CALL_TRANSACTION;
-
-    private void sendFeedback() {
-        Intent intent = new Intent(Intent.ACTION_BUG_REPORT);
-        intent.setComponent(new ComponentName(FEEDBACK_PACKAGE, FEEDBACK_CLASS));
-        if (getPackageManager().resolveService(intent, 0) == null) {
-            Log.e(TAG, "Unable to resolve Feedback service.");
-            return;
-        }
-
-        ServiceConnection conn = new ServiceConnection() {
-            @Override
-            public void onServiceConnected(ComponentName name, IBinder service) {
-                try {
-                    Parcel parcel = Parcel.obtain();
-                    if (sScreenshot != null) {
-                        sScreenshot.writeToParcel(parcel, 0);
-                    }
-                    service.transact(SEND_FEEDBACK_INFO, parcel, null, 0);
-                    parcel.recycle();
-                } catch (RemoteException ex) {
-                    Log.e(TAG, "Unexpected error sending feedback: ", ex);
-                }
-            }
-
-            @Override
-            public void onServiceDisconnected(ComponentName name) {}
-        };
-
-        bindService(intent, conn, BIND_AUTO_CREATE);
-    }
-
     /** Launches the Help activity. */
     public static void launch(Activity activity, String helpUrl) {
         View rootView = activity.getWindow().getDecorView().getRootView();
         sScreenshot = UiUtils.generateScaledScreenshot(rootView, MAX_FEEDBACK_SCREENSHOT_DIMENSION,
                 Bitmap.Config.ARGB_8888);
 
         Intent intent = new Intent(activity, HelpActivity.class);
         intent.setData(Uri.parse(helpUrl));
         activity.startActivity(intent);
     }
@@ skipping 52 matching lines @@
     }
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         int id = item.getItemId();
         if (id == android.R.id.home) {
             finish();
             return true;
         }
         if (id == R.id.actionbar_feedback) {
-            sendFeedback();
+            FeedbackSender.sendFeedback(this, sScreenshot);
             return true;
         }
         if (id == R.id.actionbar_play_store) {
             ChromotingUtil.openUrl(this, Uri.parse(PLAY_STORE_URL + getPackageName()));
             return true;
         }
         if (id == R.id.actionbar_credits) {
             startActivity(new Intent(this, CreditsActivity.class));
             return true;
         }
         return super.onOptionsItemSelected(item);
     }
 }