Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2381543002: Remove RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam (Closed)

Created:
4 years, 2 months ago by manzagop (departed)
Modified:
4 years, 2 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RelaunchChromeBrowserWithNewCommandLineIfNeeded log spam Only a subset of processes are expected to have a RelaunchChromeBrowserWithNewCommandLineIfNeeded function. Only log a message for those processes. BUG=648185 Committed: https://crrev.com/70545eff7b8d5b7502e652965d673f88f871d33a Cr-Commit-Position: refs/heads/master@{#421603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/app/main_dll_loader_win.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
manzagop (departed)
As discussed!
4 years, 2 months ago (2016-09-28 14:14:20 UTC) #4
grt (UTC plus 2)
lgtm Thanks!
4 years, 2 months ago (2016-09-28 19:23:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381543002/1
4 years, 2 months ago (2016-09-28 19:24:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 19:29:40 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 19:32:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70545eff7b8d5b7502e652965d673f88f871d33a
Cr-Commit-Position: refs/heads/master@{#421603}

Powered by Google App Engine
This is Rietveld 408576698