test/unittests/compiler/js-create-lowering-unittest.cc - Issue 2381523002: [Turbofan] Introduce OtherNumberConstant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/js-create-lowering-unittest.cc

Issue 2381523002: [Turbofan] Introduce OtherNumberConstant. (Closed)

Patch Set: Better DCHECK in HeapConstantType(). Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/js-create-lowering-unittest.cc

diff --git a/test/unittests/compiler/js-create-lowering-unittest.cc b/test/unittests/compiler/js-create-lowering-unittest.cc

index ebb16334018575d53a3987afc22bdcf681512072..cf2955356484b6dca244167f634f894297e28109 100644

--- a/test/unittests/compiler/js-create-lowering-unittest.cc

+++ b/test/unittests/compiler/js-create-lowering-unittest.cc

@@ -65,7 +65,7 @@ class JSCreateLoweringTest : public TypedGraphTest {

TEST_F(JSCreateLoweringTest, JSCreate) {

Handle<JSFunction> function = isolate()->object_function();

- Node* const target = Parameter(Type::Constant(function, graph()->zone()));

+ Node* const target = Parameter(Type::HeapConstant(function, graph()->zone()));

Node* const context = Parameter(Type::Any());

Node* const effect = graph()->start();

Reduction r = Reduce(graph()->NewNode(javascript()->Create(), target, target,