Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 2381523002: [Turbofan] Introduce OtherNumberConstant. (Closed)
Patch Set: Better DCHECK in HeapConstantType(). Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/operation-typer.cc ('k') | src/compiler/typed-optimization.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/address-map.h" 9 #include "src/address-map.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 1013 matching lines...) Expand 10 before | Expand all | Expand 10 after
1024 value_representation == MachineRepresentation::kTaggedSigned) { 1024 value_representation == MachineRepresentation::kTaggedSigned) {
1025 // Write barriers are only for stores of heap objects. 1025 // Write barriers are only for stores of heap objects.
1026 return kNoWriteBarrier; 1026 return kNoWriteBarrier;
1027 } 1027 }
1028 if (field_type->Is(Type::BooleanOrNullOrUndefined()) || 1028 if (field_type->Is(Type::BooleanOrNullOrUndefined()) ||
1029 value_type->Is(Type::BooleanOrNullOrUndefined())) { 1029 value_type->Is(Type::BooleanOrNullOrUndefined())) {
1030 // Write barriers are not necessary when storing true, false, null or 1030 // Write barriers are not necessary when storing true, false, null or
1031 // undefined, because these special oddballs are always in the root set. 1031 // undefined, because these special oddballs are always in the root set.
1032 return kNoWriteBarrier; 1032 return kNoWriteBarrier;
1033 } 1033 }
1034 if (value_type->IsConstant() && 1034 if (value_type->IsHeapConstant() &&
1035 value_type->AsConstant()->Value()->IsHeapObject()) { 1035 value_type->AsHeapConstant()->Value()->IsHeapObject()) {
1036 Handle<HeapObject> value_object = 1036 Handle<HeapObject> value_object =
1037 Handle<HeapObject>::cast(value_type->AsConstant()->Value()); 1037 Handle<HeapObject>::cast(value_type->AsHeapConstant()->Value());
1038 RootIndexMap root_index_map(jsgraph_->isolate()); 1038 RootIndexMap root_index_map(jsgraph_->isolate());
1039 int root_index = root_index_map.Lookup(*value_object); 1039 int root_index = root_index_map.Lookup(*value_object);
1040 if (root_index != RootIndexMap::kInvalidRootIndex && 1040 if (root_index != RootIndexMap::kInvalidRootIndex &&
1041 jsgraph_->isolate()->heap()->RootIsImmortalImmovable(root_index)) { 1041 jsgraph_->isolate()->heap()->RootIsImmortalImmovable(root_index)) {
1042 // Write barriers are unnecessary for immortal immovable roots. 1042 // Write barriers are unnecessary for immortal immovable roots.
1043 return kNoWriteBarrier; 1043 return kNoWriteBarrier;
1044 } 1044 }
1045 if (value_object->IsMap()) { 1045 if (value_object->IsMap()) {
1046 // Write barriers for storing maps are cheaper. 1046 // Write barriers for storing maps are cheaper.
1047 return kMapWriteBarrier; 1047 return kMapWriteBarrier;
(...skipping 2195 matching lines...) Expand 10 before | Expand all | Expand 10 after
3243 isolate(), graph()->zone(), callable.descriptor(), 0, flags, 3243 isolate(), graph()->zone(), callable.descriptor(), 0, flags,
3244 Operator::kNoProperties); 3244 Operator::kNoProperties);
3245 to_number_operator_.set(common()->Call(desc)); 3245 to_number_operator_.set(common()->Call(desc));
3246 } 3246 }
3247 return to_number_operator_.get(); 3247 return to_number_operator_.get();
3248 } 3248 }
3249 3249
3250 } // namespace compiler 3250 } // namespace compiler
3251 } // namespace internal 3251 } // namespace internal
3252 } // namespace v8 3252 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/operation-typer.cc ('k') | src/compiler/typed-optimization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698