[Turbofan] Introduce OtherNumberConstant.

src/compiler/typer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/typer.h"
 
 #include <iomanip>
 
 #include "src/base/flags.h"
 #include "src/bootstrapper.h"
@@ skipping 575 matching lines @@
 Type* Typer::Visitor::TypeFloat64Constant(Node* node) {
   UNREACHABLE();
   return nullptr;
 }
 
 
 Type* Typer::Visitor::TypeNumberConstant(Node* node) {
   Factory* f = isolate()->factory();
   double number = OpParameter<double>(node);
   if (Type::IsInteger(number)) {
     return Type::Range(number, number, zone());

[mvstanton, 2016/09/28 14:47:44]

Type::IsInteger... remove that! Factory covers it!

[mvstanton, 2016/10/04 11:55:55]

Done.

   }
-  return Type::Constant(f->NewNumber(number), zone());
+  return Type::NewConstant(f->NewNumber(number), zone());
 }
 
 
 Type* Typer::Visitor::TypeHeapConstant(Node* node) {
   return TypeConstant(OpParameter<Handle<HeapObject>>(node));
 }
 
 
 Type* Typer::Visitor::TypeExternalConstant(Node* node) {
   return Type::Internal();
@@ skipping 408 matching lines @@
   } else if (type->Is(Type::Union(Type::Undefined(), Type::OtherUndetectable(),
                                   t->zone()))) {
     return Type::Constant(f->undefined_string(), t->zone());
   } else if (type->Is(Type::Null())) {
     return Type::Constant(f->object_string(), t->zone());
   } else if (type->Is(Type::Function())) {
     return Type::Constant(f->function_string(), t->zone());
   } else if (type->IsConstant()) {
     return Type::Constant(
         Object::TypeOf(t->isolate(), type->AsConstant()->Value()), t->zone());
+  } else if (type->IsNumberConstant()) {
+    return Type::Constant(f->number_string(), t->zone());
   }
   return Type::InternalizedString();
 }
 
 
 Type* Typer::Visitor::TypeJSTypeOf(Node* node) {
   return TypeUnaryOp(node, JSTypeOfTyper);
 }
 
 
@@ skipping 673 matching lines @@
 Type* Typer::Visitor::TypeArrayBufferWasNeutered(Node* node) {
   return Type::Boolean();
 }
 
 // Heap constants.
 
 Type* Typer::Visitor::TypeConstant(Handle<Object> value) {
   if (Type::IsInteger(*value)) {
     return Type::Range(value->Number(), value->Number(), zone());
   }
-  return Type::Constant(value, zone());
+  return Type::NewConstant(value, zone());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8