PlzNav: Fix NavigationControllerBrowserTest.EnsureSamePageNavigationUpdatesFrameNaviga…

content/browser/frame_host/navigation_controller_impl_browsertest.cc

Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index 5e91cccc414b761646daab7389c76148150b996a..fa749d8337011bccb5a8a52c951d178386205734 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -6049,12 +6049,14 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
   // Simulate the user hitting Enter in the omnibox without changing the URL.
   {
     TestNavigationObserver observer(web_contents);
-    web_contents->GetController().LoadURL(web_contents->GetLastCommittedURL(),
-                                          Referrer(), ui::PAGE_TRANSITION_LINK,
-                                          std::string());
+    web_contents->GetController().LoadURL(
+        web_contents->GetLastCommittedURL(), Referrer(),
+        ui::PAGE_TRANSITION_RELOAD, std::string());

[clamy, 2016/10/05 12:47:04]

Are we sure that in the case described above we would get a
ui::PAGE_TRANSITION_RELOAD? I know that in NavigationController we do have a
special case for the user wanted to navigate to the same url but didn't actually
click on the reload button. I suspect we may not get a value of RELOAD in that
case.

[nasko, 2016/10/05 22:07:09]

You are correct. Selecting the current URL in the omnibox and hitting enter does
not result in a RELOAD transition. The usage of LINK is *intentional*. When the
commit comes back to the browser, it matches the pending navigation entry and we
classify it as SAME_PAGE.
The question is why is this not classified as SAME_PAGE in PlzNavigate here. It
looks like we have a browser test for that -
NavigationTypeClassification_SamePage, which is passing.

     observer.Wait();
   }
 
+  EXPECT_EQ(2, web_contents->GetController().GetEntryCount());
+
   // Prior to fixing the issue, the above omnibox navigation (which is
   // classified as SAME_PAGE) was leaving the FrameNavigationEntry with the
   // same document sequence number as the previous entry but updates the URL.