ash/resources/vector_icons/system_menu_computer.icon - Issue 2381493005: Add bluetooth device type icons on MD system tray.

Side by Side Diff: ash/resources/vector_icons/system_menu_computer.icon

Issue 2381493005: Add bluetooth device type icons on MD system tray. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ash/common/system/chromeos/bluetooth/tray_bluetooth.cc ('K') | « ash/resources/vector_icons/BUILD.gn ('k') | ash/resources/vector_icons/system_menu_computer.1x.icon » ('j') | chrome/browser/ui/ash/system_tray_delegate_chromeos.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 CANVAS_DIMENSIONS, 40,

	6 MOVE_TO, 32, 29,
	fukino 2016/09/29 16:27:36 I created icon files by 1) Download SVGs from Seb I created icon files by 1) Download SVGs from Seb's folder. 2) Optimize SVGs https://jakearchibald.github.io/svgomg/ using default options. 3) Convert them to .icon using http://evanstade.github.io/skiafy/. 4) Manually remove the first path in .icon files. The path is like as follows. It looks unnecessary and I had to remove it to show the icons properly. MOVE_TO, 0, 0, R_H_LINE_TO, 40, R_V_LINE_TO, 40, H_LINE_TO, 0, CLOSE, I'm not confident with step 4. Is there something wrong? tdanderson 2016/09/29 18:54:39 Yes, step 4 is correct - without it you probably n Show quoted text On 2016/09/29 16:27:36, fukino wrote: > I created icon files by > 1) Download SVGs from Seb's folder. > 2) Optimize SVGs https://jakearchibald.github.io/svgomg/ using default options. > 3) Convert them to .icon using http://evanstade.github.io/skiafy/. > 4) Manually remove the first path in .icon files. The path is like as follows. > It looks unnecessary and I had to remove it to show the icons properly. > > MOVE_TO, 0, 0, > R_H_LINE_TO, 40, > R_V_LINE_TO, 40, > H_LINE_TO, 0, > CLOSE, > > I'm not confident with step 4. Is there something wrong? Yes, step 4 is correct - without it you probably noticed that the colors were inverted. See "Why is the outside of my icon being filled instead of the inside?" in https://www.chromium.org/developers/how-tos/vectorized-icons-in-native-chrome-ui fukino 2016/09/30 02:43:49 Thank you for the information. I didn't noticed th Show quoted text On 2016/09/29 18:54:39, tdanderson wrote: > On 2016/09/29 16:27:36, fukino wrote: > > I created icon files by > > 1) Download SVGs from Seb's folder. > > 2) Optimize SVGs https://jakearchibald.github.io/svgomg/ using default > options. > > 3) Convert them to .icon using http://evanstade.github.io/skiafy/. > > 4) Manually remove the first path in .icon files. The path is like as > follows. > > It looks unnecessary and I had to remove it to show the icons properly. > > > > MOVE_TO, 0, 0, > > R_H_LINE_TO, 40, > > R_V_LINE_TO, 40, > > H_LINE_TO, 0, > > CLOSE, > > > > I'm not confident with step 4. Is there something wrong? > > Yes, step 4 is correct - without it you probably noticed that the colors were > inverted. See "Why is the outside of my icon being filled instead of the > inside?" in > https://www.chromium.org/developers/how-tos/vectorized-icons-in-native-chrome-ui Thank you for the information. I didn't noticed that it was already documented. Sorry!
	7 R_CUBIC_TO, 1.65f, 0, 2.99f, -1.35f, 2.99f, -3,

	8 LINE_TO, 35, 11,

	9 R_CUBIC_TO, 0, -1.65f, -1.35f, -3, -3, -3,

	10 H_LINE_TO, 8,

	11 R_CUBIC_TO, -1.65f, 0, -3, 1.35f, -3, 3,

	12 R_V_LINE_TO, 15,

	13 R_CUBIC_TO, 0, 1.65f, 1.35f, 3, 3, 3,

	14 H_LINE_TO, 2,

	15 R_V_LINE_TO, 3,

	16 R_H_LINE_TO, 36,

	17 R_V_LINE_TO, -3,

	18 R_H_LINE_TO, -6,

	19 CLOSE,

	20 MOVE_TO, 8, 11,

	21 R_H_LINE_TO, 24,

	22 R_V_LINE_TO, 15,

	23 H_LINE_TO, 8,

	24 V_LINE_TO, 11,

	25 CLOSE,

	26 END

OLD	NEW