[heap] Set progress bar flag for FixedArray upon allocation

[heap] Set progress bar flag for FixedArray upon allocation

R=hpayer@chromium.org
TEST=test-heap/Regress598319

Committed: https://crrev.com/eb582256d6fb2820727c0499cbf11f860bc660c2
Cr-Commit-Position: refs/heads/master@{#39912}

[Michael Lippautz, 2016-09-29 10:15:55]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2016-09-29 10:16:50]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 10:16:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 10:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 10:52:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Michael Lippautz, 2016-09-29 11:09:05]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 11:09:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 11:37:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:37:35]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-09-29 12:06:22]

Description was changed from

==========
[heap] Set progress bar flag for FixedArray upon allocation

BUG=
==========

to

==========
[heap] Set progress bar flag for FixedArray upon allocation

BUG=
TEST=test-heap/Regress598319
==========

[Michael Lippautz, 2016-09-29 12:07:45]

Description was changed from

==========
[heap] Set progress bar flag for FixedArray upon allocation

BUG=
TEST=test-heap/Regress598319
==========

to

==========
[heap] Set progress bar flag for FixedArray upon allocation

R=hpayer@chromium.org
TEST=test-heap/Regress598319
==========

[Michael Lippautz, 2016-09-29 12:07:45]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-09-29 12:07:59]

ptal, another smaller issue

[Michael Lippautz, 2016-09-29 14:12:15]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 14:12:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 14:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 14:53:52]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-09-30 10:32:41]

lgtm

https://codereview.chromium.org/2381493004/diff/60001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (left):

https://codereview.chromium.org/2381493004/diff/60001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:191: if (FLAG_use_marking_progress_bar &&
Let's make that a DCHECK.

[Michael Lippautz, 2016-09-30 10:36:14]

https://codereview.chromium.org/2381493004/diff/60001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (left):

https://codereview.chromium.org/2381493004/diff/60001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:191: if (FLAG_use_marking_progress_bar &&
On 2016/09/30 10:32:41, Hannes Payer wrote:
> Let's make that a DCHECK.

Done.

[Michael Lippautz, 2016-09-30 10:36:22]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-09-30 10:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2381493004/#ps80001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-09-30 10:36:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-09-30 10:40:44]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-09-30 10:40:44]

Woot! I like it. LGTM!

[commit-bot: I haz the power, 2016-09-30 10:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 10:41:39]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25429)

[Toon Verwaest, 2016-09-30 10:44:25]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-09-30 10:44:26]

lgtm

[Michael Lippautz, 2016-09-30 11:10:35]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-09-30 11:10:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 11:13:42]

Description was changed from

==========
[heap] Set progress bar flag for FixedArray upon allocation

R=hpayer@chromium.org
TEST=test-heap/Regress598319
==========

to

==========
[heap] Set progress bar flag for FixedArray upon allocation

R=hpayer@chromium.org
TEST=test-heap/Regress598319
==========

[commit-bot: I haz the power, 2016-09-30 11:13:43]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-30 11:13:59]

Description was changed from

==========
[heap] Set progress bar flag for FixedArray upon allocation

R=hpayer@chromium.org
TEST=test-heap/Regress598319
==========

to

==========
[heap] Set progress bar flag for FixedArray upon allocation

R=hpayer@chromium.org
TEST=test-heap/Regress598319

Committed: https://crrev.com/eb582256d6fb2820727c0499cbf11f860bc660c2
Cr-Commit-Position: refs/heads/master@{#39912}
==========

[commit-bot: I haz the power, 2016-09-30 11:14:00]

Patchset 4 (id:??) landed as
https://crrev.com/eb582256d6fb2820727c0499cbf11f860bc660c2
Cr-Commit-Position: refs/heads/master@{#39912}