Move ViewMsg_New to mojom

Move ViewMsg_New to mojom

This is added to a new content::mojom::Renderer interface which
is intended to define any messages processed directly by
RenderThreadImpl.

Also moves ViewMsg_New_Params to a mojom struct and adds
native typemaps for some of its dependencies.

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/067ca55f59d8fcc92db8d4eb3551ef31b7b43119
Cr-Commit-Position: refs/heads/master@{#422236}

[Ken Rockot(use gerrit already), 2016-09-28 18:25:30]

Description was changed from

==========
Move ViewMsg_New to mojom

This is added to a new content::mojom::Renderer interface which
is intended to define any messages processed directly by
RenderThreadImpl.

Also moves ViewMsg_New_Params to a mojom struct and adds
native typemaps for some of its dependencies.

BUG=612500
==========

to

==========
Move ViewMsg_New to mojom

This is added to a new content::mojom::Renderer interface which
is intended to define any messages processed directly by
RenderThreadImpl.

Also moves ViewMsg_New_Params to a mojom struct and adds
native typemaps for some of its dependencies.

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ken Rockot(use gerrit already), 2016-09-28 18:25:32]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 18:25:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 18:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 18:30:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-09-28 20:49:57]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 20:50:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 21:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 21:20:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-09-28 23:04:17]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 23:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-28 23:30:21]

rockot@chromium.org changed reviewers:
+ dcheng@chromium.org, nick@chromium.org, sky@chromium.org

[Ken Rockot(use gerrit already), 2016-09-28 23:30:22]

Another CL for your reviewing pleasure. Please take a look:

dcheng@ for mojom and typemaps (mostly native ParamTraits mappings and awful
build rules)
nick@ for content/
sky@ for ui/

Thanks!

[sky, 2016-09-29 00:07:36]

LGTM

[commit-bot: I haz the power, 2016-09-29 00:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:11:14]

Dry run: Exceeded global retry quota

[ncarter (slow), 2016-09-29 16:49:32]

lgtm

https://codereview.chromium.org/2381493003/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2381493003/diff/40001/content/renderer/render...
content/renderer/render_thread_impl.cc:352: // we want.
Is this race still actually possible?

[Ken Rockot(use gerrit already), 2016-09-29 23:58:08]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 23:58:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 00:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 00:03:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-09-30 00:08:22]

Ping dcheng@ - I still have some annoying dependency issue to work out for the
typemaps, but otherwise this is good for review

[Ken Rockot(use gerrit already), 2016-09-30 00:08:57]

https://codereview.chromium.org/2381493003/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2381493003/diff/40001/content/renderer/render...
content/renderer/render_thread_impl.cc:352: // we want.
On 2016/09/29 at 16:49:32, ncarter wrote:
> Is this race still actually possible?

Yeah, since this pipe is not associated with the channel, there's no ordering
guarantees on it.

[dcheng, 2016-09-30 06:30:37]

LGTM

+ccameron as FYI for the icc profile stuff

https://codereview.chromium.org/2381493003/diff/60001/ipc/ipc.mojom
File ipc/ipc.mojom (right):

https://codereview.chromium.org/2381493003/diff/60001/ipc/ipc.mojom#newcode8
ipc/ipc.mojom:8: const int32 ROUTING_ID_NONE = -2;
Should this be named kRoutingIdNone to reflect the conventions around naming
constants? Or is SHOUTY_CASE explicitly preferred for Java/JS interop?

https://codereview.chromium.org/2381493003/diff/60001/ui/gfx/mojo/icc_profile...
File ui/gfx/mojo/icc_profile_struct_traits.h (right):

https://codereview.chromium.org/2381493003/diff/60001/ui/gfx/mojo/icc_profile...
ui/gfx/mojo/icc_profile_struct_traits.h:28: std::unique_ptr<std::vector<int8_t>>
data =
Nit: out of line SetUpContext / TearDownContext.

[Ken Rockot(use gerrit already), 2016-09-30 15:26:03]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 15:26:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 15:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:50:05]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Rockot(use gerrit already), 2016-09-30 16:44:42]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 17:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 17:09:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Rockot(use gerrit already), 2016-09-30 20:02:13]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-09-30 20:02:24]

Patchset #6 (id:100001) has been deleted

[Ken Rockot(use gerrit already), 2016-09-30 20:02:29]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-09-30 20:02:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-30 20:02:54]

https://codereview.chromium.org/2381493003/diff/60001/ipc/ipc.mojom
File ipc/ipc.mojom (right):

https://codereview.chromium.org/2381493003/diff/60001/ipc/ipc.mojom#newcode8
ipc/ipc.mojom:8: const int32 ROUTING_ID_NONE = -2;
On 2016/09/30 at 06:30:37, dcheng wrote:
> Should this be named kRoutingIdNone to reflect the conventions around naming
constants? Or is SHOUTY_CASE explicitly preferred for Java/JS interop?

Done. I think I was just tricked by the definition of MSG_ROUTING_NONE.

https://codereview.chromium.org/2381493003/diff/60001/ui/gfx/mojo/icc_profile...
File ui/gfx/mojo/icc_profile_struct_traits.h (right):

https://codereview.chromium.org/2381493003/diff/60001/ui/gfx/mojo/icc_profile...
ui/gfx/mojo/icc_profile_struct_traits.h:28: std::unique_ptr<std::vector<int8_t>>
data =
On 2016/09/30 at 06:30:37, dcheng wrote:
> Nit: out of line SetUpContext / TearDownContext.

Better: I removed these and eliminated the extra copying. Per our off-thread
discussion I attempted to change ICCProfile to use uint8_t for storage, but it
turns out that the vector<char> gets passed around all over the place and the CL
started to explode in size.

Changed the mojom type to use a string instead, and conveniently the traits can
just return a base::StringPiece over the internal vector<char>.

[Ken Rockot(use gerrit already), 2016-09-30 20:51:28]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-09-30 20:53:42]

mojo still lgtm

[commit-bot: I haz the power, 2016-09-30 21:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:51:36]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-09-30 21:52:40]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-09-30 21:52:40]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2381493003/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-09-30 21:53:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:00:40]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-09-30 22:03:42]

Description was changed from

==========
Move ViewMsg_New to mojom

This is added to a new content::mojom::Renderer interface which
is intended to define any messages processed directly by
RenderThreadImpl.

Also moves ViewMsg_New_Params to a mojom struct and adds
native typemaps for some of its dependencies.

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move ViewMsg_New to mojom

This is added to a new content::mojom::Renderer interface which
is intended to define any messages processed directly by
RenderThreadImpl.

Also moves ViewMsg_New_Params to a mojom struct and adds
native typemaps for some of its dependencies.

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/067ca55f59d8fcc92db8d4eb3551ef31b7b43119
Cr-Commit-Position: refs/heads/master@{#422236}
==========

[commit-bot: I haz the power, 2016-09-30 22:03:43]

Patchset 6 (id:??) landed as
https://crrev.com/067ca55f59d8fcc92db8d4eb3551ef31b7b43119
Cr-Commit-Position: refs/heads/master@{#422236}