Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2381483002: Fix spec reference to non-existing mirrors method. (Closed)

Created:
4 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 2 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix spec reference to non-existing mirrors method. Fixes #25549 BUG= https://dartbug.com/25549 R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/b98484fbc1b369b272341b613a13bd6039e2ca73

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M docs/language/dartLangSpec.tex View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
4 years, 2 months ago (2016-09-28 11:13:10 UTC) #2
eernst
LGTM https://codereview.chromium.org/2381483002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2381483002/diff/1/docs/language/dartLangSpec.tex#newcode2875 docs/language/dartLangSpec.tex:2875: A symbol literal \code{\#\_id} evaluates to the object ...
4 years, 2 months ago (2016-09-28 11:35:01 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as b98484fbc1b369b272341b613a13bd6039e2ca73 (presubmit successful).
4 years, 2 months ago (2016-09-28 11:38:19 UTC) #5
Lasse Reichstein Nielsen
4 years, 2 months ago (2016-09-28 11:38:26 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2381483002/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2381483002/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:2875: A symbol literal \code{\#\_id} evaluates to
the object that would be returned by the call
\code{MirrorSystem.getSymbol('_id', mirror)} where \code{mirror} is an instance
of the class \code{LibraryMirror} defined in the library \code{dart:mirrors},
reflecting the current library.
On 2016/09/28 11:35:00, eernst wrote:
> I'd prefer calling it \code{libraryMirror}, giving the reader an earlier and
> in-context hint about its nature.

Done.

Powered by Google App Engine
This is Rietveld 408576698