Remove psutil from the mini_installer test framework.

chrome/test/mini_installer/chrome_helper.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Common helper module for working with Chrome's processes and windows."""
 
-import psutil
+import ctypes
+import pywintypes
 import re
+import win32con
 import win32gui
 import win32process
 
 import path_resolver
 
 
+def GetProcessIDAndPathPairs():
+  """Returns a list of 2-tuples of (process id, process path)."""

[gab, 2013/08/30 16:20:21]

Nice work; perhaps add a comment here saying that this is needed because psutil
is only available as of python 2.7 (with a link to the infrastructure bug)?

So that if someone in the future wonders why this doesn't use the much simpler
psutil approach instead they can know that it's safe to replace this with psutil
as long as python 2.7 made it onto the bots?

[sukolsak, 2013/08/30 19:03:36]

Done. psutil is available on Python 2.6, but it's not installed on Windows slave
machines (see https://code.google.com/p/chromium/issues/detail?id=257696.) It
seems unlikely to be fixed anytime soon.

+  process_id_and_path_pairs = []
+  for process_id in win32process.EnumProcesses():
+    process_handle = ctypes.windll.kernel32.OpenProcess(
+        win32con.PROCESS_QUERY_INFORMATION | win32con.PROCESS_VM_READ, False,
+        process_id)
+    if not process_handle:
+      continue
+    try:
+      process_path = win32process.GetModuleFileNameEx(process_handle, 0)
+      process_id_and_path_pairs.append((process_id, process_path))
+    except pywintypes.error:
+      # It's normal that some processes are not accessible.
+      pass
+  return process_id_and_path_pairs
+
+
 def GetProcessIDs(process_path):
   """Returns a list of IDs of processes whose path is |process_path|.
 
   Args:
     process_path: The path to the process.
 
   Returns:
     A list of process IDs.
   """
   process_ids = []
-  for process in psutil.process_iter():
-    try:
-      found_process_path = process.exe
-      if found_process_path == process_path:
-        process_ids.append(process.pid)
-    except psutil.AccessDenied:
-      # It's normal that some processes are not accessible.
-      pass
+  for found_process_id, found_process_path in GetProcessIDAndPathPairs():
+    if found_process_path == process_path:
+      process_ids.append(found_process_id)
   return process_ids
 
 
 def GetWindowHandles(process_ids):
   """Returns a list of handles of windows owned by processes in |process_ids|.
 
   Args:
     process_ids: A list of process IDs.
 
   Returns:
@@ skipping 30 matching lines @@
 
 
 def GetChromePath(system_level):
   """Returns the path to Chrome, at the |system_level| or user level."""
   chrome_path = None
   if system_level:
     chrome_path = '$PROGRAM_FILES\\$CHROME_DIR\\Application\\chrome.exe'
   else:
     chrome_path = '$LOCAL_APPDATA\\$CHROME_DIR\\Application\\chrome.exe'
   return path_resolver.ResolvePath(chrome_path)