Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2381393002: [wasm] further simplification of WasmCompiledModule (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Committed: https://crrev.com/6ea3575c3cfd81489d62f14e62460ba13b8ddd13 Cr-Original-Commit-Position: refs/heads/master@{#39923} Cr-Commit-Position: refs/heads/master@{#39925}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -61 lines) Patch
M src/wasm/wasm-module.h View 3 chunks +17 lines, -37 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 10 chunks +41 lines, -24 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
Mircea Trofin
4 years, 2 months ago (2016-09-30 21:32:59 UTC) #5
bradnelson
lgtm
4 years, 2 months ago (2016-09-30 22:58:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381393002/1
4 years, 2 months ago (2016-09-30 22:58:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 23:01:54 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923}
4 years, 2 months ago (2016-09-30 23:02:15 UTC) #15
Mircea Trofin
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2385943002/ by mtrofin@chromium.org. ...
4 years, 2 months ago (2016-10-01 00:05:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381393002/20001
4 years, 2 months ago (2016-10-01 00:42:54 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-01 00:45:36 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 00:45:56 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ea3575c3cfd81489d62f14e62460ba13b8ddd13
Cr-Commit-Position: refs/heads/master@{#39925}

Powered by Google App Engine
This is Rietveld 408576698