|
|
Created:
4 years, 2 months ago by Mircea Trofin Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] further simplification of WasmCompiledModule
Calculate memory size from the available heap. This avoids
the bugs due to some numbers being stored as objects (by-ref)
and thus needing special handling when cloning.
This leaves all the rest of the numbers as read-only.
Further simplified by representing globals size as a Smi.
BUG=
Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57
Committed: https://crrev.com/6ea3575c3cfd81489d62f14e62460ba13b8ddd13
Cr-Original-Commit-Position: refs/heads/master@{#39923}
Cr-Commit-Position: refs/heads/master@{#39925}
Patch Set 1 #Patch Set 2 : fix #
Messages
Total messages: 28 (19 generated)
Description was changed from ========== [wasm] further simplification of WasmCompiledModule BUG= ========== to ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@google.com
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bradnelson@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= ========== to ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= ========== to ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2385943002/ by mtrofin@chromium.org. The reason for reverting is: Failures on multiple bots (e.g. https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds...).
Message was sent while issue was closed.
Description was changed from ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923} ========== to ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923} ==========
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2381393002/#ps20001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923} ========== to ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Cr-Commit-Position: refs/heads/master@{#39923} ========== to ========== [wasm] further simplification of WasmCompiledModule Calculate memory size from the available heap. This avoids the bugs due to some numbers being stored as objects (by-ref) and thus needing special handling when cloning. This leaves all the rest of the numbers as read-only. Further simplified by representing globals size as a Smi. BUG= Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 Committed: https://crrev.com/6ea3575c3cfd81489d62f14e62460ba13b8ddd13 Cr-Original-Commit-Position: refs/heads/master@{#39923} Cr-Commit-Position: refs/heads/master@{#39925} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6ea3575c3cfd81489d62f14e62460ba13b8ddd13 Cr-Commit-Position: refs/heads/master@{#39925} |