Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2381373003: Fixed the issue shows keyword hint when omnibox loses its focus. (Closed)

Created:
4 years, 2 months ago by cwdoh
Modified:
3 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed the issue that shows keyword hint when omnibox loses its focus. Keyword hint displays a message 'tab for search', but it cannot use when omnibox loses its focus. Checking focus states for determining the visibility of keyword hint in Layout(), and calling layout() when focus changes would solve this issue. This patch is written for OSX Chrome, patches for other platforms may be around here. :) BUG=649938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 5 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
cwdoh
PTAL
4 years, 2 months ago (2016-10-01 03:55:25 UTC) #3
cwdoh
PTAL.
4 years, 2 months ago (2016-10-04 02:34:50 UTC) #9
Peter Kasting
Are you aware of https://codereview.chromium.org/2373773002/ , which fixes this on the views side only? Please ...
4 years, 2 months ago (2016-10-05 00:22:17 UTC) #15
Peter Kasting
What's the status of this CL?
3 years, 10 months ago (2017-02-11 01:58:03 UTC) #16
Peter Kasting
3 years, 3 months ago (2017-08-29 03:38:20 UTC) #17
Closing; no response from author, other patch landed, bug is marked fixed

Powered by Google App Engine
This is Rietveld 408576698