Disable caret blinking for blimp

blimp/engine/session/tab.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/session/tab.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "base/trace_event/trace_event.h"
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/common/proto/render_widget.pb.h"
 #include "blimp/common/proto/tab_control.pb.h"
 #include "blimp/engine/common/blimp_user_agent.h"
 #include "blimp/engine/feature/engine_render_widget_feature.h"
 #include "blimp/net/blimp_message_processor.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/renderer_preferences.h"
 #include "ui/aura/window.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace blimp {
 namespace engine {
 
 Tab::Tab(std::unique_ptr<content::WebContents> web_contents,
          const int tab_id,
          EngineRenderWidgetFeature* render_widget_feature,
          BlimpMessageProcessor* navigation_message_sender)
@@ skipping 64 matching lines @@
   web_contents_->GetController().GoForward();
 }
 
 void Tab::Reload() {
   DVLOG(1) << "Reload in tab " << tab_id_;
   web_contents_->GetController().Reload(true);
 }
 
 void Tab::RenderViewCreated(content::RenderViewHost* render_view_host) {
   DCHECK(render_view_host);
+  web_contents_->GetMutableRendererPrefs()->caret_blink_interval = 0;
+  render_view_host->SyncRendererPrefs();

[Khushal, 2016/10/10 18:57:09]

Would it be nicer if content gave a callback before the Prefs are sent to the
renderer, something along the lines of:
https://cs.chromium.org/chromium/src/content/public/browser/content_browser_c...

+
   render_widget_feature_->OnRenderWidgetCreated(tab_id_,
                                                 render_view_host->GetWidget());
 }
 
 void Tab::RenderViewHostChanged(content::RenderViewHost* old_host,
                                 content::RenderViewHost* new_host) {
   render_widget_feature_->OnRenderWidgetInitialized(tab_id_,
                                                     new_host->GetWidget());
 }
 
@@ skipping 51 matching lines @@
 void Tab::OnCompositorMessageReceived(
     content::RenderWidgetHost* render_widget_host,
     const std::vector<uint8_t>& message) {
   TRACE_EVENT0("blimp", "Tab::OnCompositorMessageReceived");
 
   render_widget_host->HandleCompositorProto(message);
 }
 
 }  // namespace engine
 }  // namespace blimp