Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2381363002: Set minimum height of error list in Extension debugging UI (Closed)

Created:
4 years, 2 months ago by elawrence
Modified:
4 years, 2 months ago
Reviewers:
*Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set minimum height of error list in Extension debugging UI Previously, the error list could be unusably small (depending on the vertical height of the Chrome window). Now we set a minimum bound to ensure that at least one error is visible and any scrollbar is not too short to use. BUG=651888 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c27aa265142293fbd704d48c27aacb7d6ac7bfc7 Cr-Commit-Position: refs/heads/master@{#422313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/extensions/extension_error_overlay.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
elawrence
Please have a look per your kind offer from March 3rd. :)
4 years, 2 months ago (2016-09-30 19:30:21 UTC) #4
Devlin
lgtm
4 years, 2 months ago (2016-10-01 01:03:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381363002/1
4 years, 2 months ago (2016-10-01 13:16:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 13:56:59 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 13:58:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c27aa265142293fbd704d48c27aacb7d6ac7bfc7
Cr-Commit-Position: refs/heads/master@{#422313}

Powered by Google App Engine
This is Rietveld 408576698