Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238133002: Don't create CertVerifier in SslHmacChannelAuthenticator (Closed)

Created:
6 years, 8 months ago by Sergey Ulanov
Modified:
6 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Don't create CertVerifier in SslHmacChannelAuthenticator CertVerifier is not useful there because SslHmacChannelAuthenticator always uses self-signed certs. BUG=276739 crrev.com/263945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M remoting/protocol/ssl_hmac_channel_authenticator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sergey Ulanov
6 years, 8 months ago (2014-04-14 23:00:31 UTC) #1
Jamie
LGTM. Thanks for separating this out.
6 years, 8 months ago (2014-04-14 23:52:17 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-04-15 01:24:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/238133002/1
6 years, 8 months ago (2014-04-15 01:26:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 02:16:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61403
6 years, 8 months ago (2014-04-15 02:16:33 UTC) #6
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-04-15 02:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/238133002/1
6 years, 8 months ago (2014-04-15 02:32:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 03:13:54 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 03:13:54 UTC) #10 
Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Powered by Google App Engine
This is Rietveld 408576698