Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2381283002: Fix Scope::CheckZones. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Scope::CheckZones. It was meant to be recursive. BUG= Committed: https://crrev.com/51bea9f0f102a9010cc04a867f0cd912528a83f2 Cr-Commit-Position: refs/heads/master@{#39910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ast/scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-30 10:43:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381283002/1
4 years, 2 months ago (2016-09-30 10:46:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 10:48:01 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 10:48:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51bea9f0f102a9010cc04a867f0cd912528a83f2
Cr-Commit-Position: refs/heads/master@{#39910}

Powered by Google App Engine
This is Rietveld 408576698