Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2381273002: Turn libbase into a component (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn libbase into a component This is a precondition for turning libplatform into a component BUG=v8:5412 R=jgruber@chromium.org,machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 Cr-Commit-Position: refs/heads/master@{#39950}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Patch Set 6 : updates #

Patch Set 7 : updates #

Patch Set 8 : updates #

Patch Set 9 : updatse #

Patch Set 10 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -115 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 12 chunks +26 lines, -7 lines 0 comments Download
M samples/samples.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/base/atomicops_internals_x86_gcc.h View 2 chunks +4 lines, -1 line 0 comments Download
A src/base/base-export.h View 1 chunk +31 lines, -0 lines 0 comments Download
M src/base/bits.h View 5 chunks +14 lines, -18 lines 0 comments Download
M src/base/cpu.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/debug/stack_trace.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/base/division-by-constant.h View 1 2 3 4 5 6 7 8 3 chunks +23 lines, -5 lines 0 comments Download
M src/base/division-by-constant.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -10 lines 0 comments Download
M src/base/file-utils.h View 1 chunk +8 lines, -5 lines 0 comments Download
M src/base/file-utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/base/functional.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +22 lines, -20 lines 0 comments Download
M src/base/logging.h View 3 chunks +8 lines, -6 lines 0 comments Download
M src/base/once.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/base/platform/condition-variable.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/platform/mutex.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/base/platform/platform.h View 1 2 3 4 5 5 chunks +5 lines, -4 lines 0 comments Download
M src/base/platform/semaphore.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/platform/time.h View 1 2 3 4 5 7 chunks +11 lines, -5 lines 0 comments Download
M src/base/sys-info.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/base/utils/random-number-generator.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/d8.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/icu_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/startup-data-util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 2 3 4 5 6 7 8 9 6 chunks +28 lines, -12 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M test/fuzzer/fuzzer.gyp View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M test/unittests/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/parser-shell.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 45 (36 generated)
jochen (gone - plz use gerrit)
ptal
4 years, 2 months ago (2016-10-04 08:14:48 UTC) #17
jochen (gone - plz use gerrit)
now with greener trybots :)
4 years, 2 months ago (2016-10-04 09:57:08 UTC) #32
jgruber
lgtm
4 years, 2 months ago (2016-10-04 10:19:33 UTC) #33
jgruber
lgtm lgtm
4 years, 2 months ago (2016-10-04 10:19:33 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381273002/180001
4 years, 2 months ago (2016-10-04 11:34:03 UTC) #40
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 2 months ago (2016-10-04 11:47:18 UTC) #41
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 Cr-Commit-Position: refs/heads/master@{#39950}
4 years, 2 months ago (2016-10-04 11:47:37 UTC) #43
Michael Achenbach
Seems to block the roll: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/279805
4 years, 2 months ago (2016-10-04 16:01:34 UTC) #44
Michael Achenbach
4 years, 2 months ago (2016-10-04 16:08:15 UTC) #45
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2393603002/ by machenbach@chromium.org.

The reason for reverting is: Main suspect for roll block:
https://codereview.chromium.org/2387403002/.

Powered by Google App Engine
This is Rietveld 408576698