Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2381233003: Prune CreateVisibleSelectionDeprecated from SpellChecker (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisibleSelectionDeprecated from SpellChecker BUG=651373 Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1 Cr-Commit-Position: refs/heads/master@{#422055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-09-30 06:43:35 UTC) #5
yosin_UTC9
lgtm
4 years, 2 months ago (2016-09-30 06:44:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381233003/1
4 years, 2 months ago (2016-09-30 07:39:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 07:43:22 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1 Cr-Commit-Position: refs/heads/master@{#422055}
4 years, 2 months ago (2016-09-30 07:44:59 UTC) #13
Xiaocheng
4 years, 2 months ago (2016-09-30 10:58:18 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2383733002/ by xiaochengh@chromium.org.

The reason for reverting is: Causing a lot of editing layout tests to fail by
hitting the DCHECK in createVisibleSelection..

Powered by Google App Engine
This is Rietveld 408576698