chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc - Issue 23812010: Implement first part of supporting global extension commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc

Issue 23812010: Implement first part of supporting global extension commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fewer if-defs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/extension_commands_global_registry_views.cc ('K') | « chrome/browser/ui/views/extensions/extension_commands_global_registry_views.cc ('k') | chrome/browser/ui/webui/extensions/command_handler.cc » ('j') | chrome/common/extensions/extension_manifest_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc

diff --git a/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc b/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc

index 1531847118ccc1914d64dc2bafac94b97d16b4ba..58778a466b612715170de02bd40c7c591df87f1d 100644

--- a/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc

+++ b/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc

@@ -47,7 +47,10 @@ void ExtensionKeybindingRegistryViews::AddExtensionKeybinding(

// which are handled elsewhere).

extensions::CommandMap commands;

if (!command_service->GetNamedCommands(

- extension->id(), extensions::CommandService::ACTIVE_ONLY, &commands))

+ extension->id(),

+ extensions::CommandService::ACTIVE_ONLY,

+ extensions::CommandService::REGULAR,

+ &commands))

return;

extensions::CommandMap::const_iterator iter = commands.begin();

for (; iter != commands.end(); ++iter) {