chrome/common/extensions/api/commands/commands_handler.cc - Issue 23812010: Implement first part of supporting global extension commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/commands/commands_handler.cc

Issue 23812010: Implement first part of supporting global extension commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Polishing a bit Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/commands/commands_handler.cc

diff --git a/chrome/common/extensions/api/commands/commands_handler.cc b/chrome/common/extensions/api/commands/commands_handler.cc

index 731af996a6e3415f647637c434dae1ffba7d3eb5..852f152ab656b693bba4aa3e91769117086ef57e 100644

--- a/chrome/common/extensions/api/commands/commands_handler.cc

+++ b/chrome/common/extensions/api/commands/commands_handler.cc

@@ -140,7 +140,8 @@ void CommandsHandler::MaybeSetBrowserActionDefault(const Extension* extension,

info->browser_action_command.reset(

new Command(manifest_values::kBrowserActionCommandEvent,

string16(),

- std::string()));

+ std::string(),

+ false));

}