Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/extensions/extension_commands_global_registry.h

Issue 23812010: Implement first part of supporting global extension commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: No change, just reuploading (last attempt was incomplete) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_commands_global_registry.h
diff --git a/chrome/browser/extensions/extension_commands_global_registry.h b/chrome/browser/extensions/extension_commands_global_registry.h
new file mode 100644
index 0000000000000000000000000000000000000000..eb0dc76554d7357360b3041b2d46a2e29b376cc0
--- /dev/null
+++ b/chrome/browser/extensions/extension_commands_global_registry.h
@@ -0,0 +1,82 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_COMMANDS_GLOBAL_REGISTRY_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_COMMANDS_GLOBAL_REGISTRY_H_
+
+#include <map>
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
+#include "chrome/browser/extensions/extension_keybinding_registry.h"
+#include "chrome/browser/extensions/global_shortcut_listener.h"
+#include "ui/base/accelerators/accelerator.h"
+
+class Profile;
+
+namespace extensions {
+class Extension;
+}
+
+namespace extensions {
+
+// ExtensionCommandsGlobalRegistry is a class that handles the cross-platform
+// implementation of the global shortcut registration for the Extension Commands
+// API).
+// Note: It handles regular extension commands (not browserAction and pageAction
+// popups, which are not bindable to global shortcuts). This class registers the
+// accelerators on behalf of the extensions and routes the commands to them via
+// the BrowserEventRouter.
+class ExtensionCommandsGlobalRegistry
+ : public ProfileKeyedAPI,
+ public ExtensionKeybindingRegistry,
+ public GlobalShortcutListener::Observer {
+ public:
+ // ProfileKeyedAPI implementation.
+ static ProfileKeyedAPIFactory<
+ ExtensionCommandsGlobalRegistry>* GetFactoryInstance();
+
+ // Convenience method to get the ExtensionCommandsGlobalRegistry for a
+ // profile.
+ static ExtensionCommandsGlobalRegistry* Get(Profile* profile);
+
+ explicit ExtensionCommandsGlobalRegistry(Profile* profile);
+ virtual ~ExtensionCommandsGlobalRegistry();
+
+ private:
+ friend class ProfileKeyedAPIFactory<ExtensionCommandsGlobalRegistry>;
+
+ // ProfileKeyedAPI implementation.
+ static const char* service_name() {
+ return "ExtensionCommandsGlobalRegistry";
+ }
+
+ // Overridden from ExtensionKeybindingRegistry:
+ virtual void AddExtensionKeybinding(
+ const Extension* extension,
+ const std::string& command_name) OVERRIDE;
+ virtual void RemoveExtensionKeybinding(
+ const Extension* extension,
+ const std::string& command_name) OVERRIDE;
+
+ // Called by the GlobalShortcutListener object when a shortcut this class has
+ // registered for has been pressed.
+ virtual void OnKeyPressed(const ui::Accelerator& accelerator) OVERRIDE;
+
+ // Weak pointer to our profile. Not owned by us.
+ Profile* profile_;
+
+ // Maps an accelerator to a string pair (extension id, command name) for
+ // commands that have been registered.
+ typedef std::map< ui::Accelerator,
+ std::pair<std::string, std::string> > EventTargets;
Yoyo Zhou 2013/10/03 22:08:50 Why is this called EventTargets? I don't see eithe
Finnur 2013/10/04 17:57:02 Moved to base class (and added a bit more comments
+ EventTargets event_targets_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionCommandsGlobalRegistry);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_COMMANDS_GLOBAL_REGISTRY_H_

Powered by Google App Engine
This is Rietveld 408576698