Implement first part of supporting global extension commands.

chrome/browser/extensions/api/commands/command_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_COMMANDS_COMMAND_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_API_COMMANDS_COMMAND_SERVICE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 27 matching lines @@
 class CommandService : public ProfileKeyedAPI,
                        public content::NotificationObserver {
  public:
   // An enum specifying whether to fetch all extension commands or only active
   // ones.
   enum QueryType {
     ALL,
     ACTIVE_ONLY,
   };
 
+  // An enum specifying whether the command is global in scope or not. Global
+  // commands -- unlike regular commands -- have a global keyboard hook
+  // associated with them (and therefore work when Chrome doesn't have focus).
+  enum CommandScope {
+    REGULAR,
+    GLOBAL,
+    ANY_SCOPE,

[Yoyo Zhou, 2013/10/03 22:08:50]

What does this mean? (This is only used for querying?)

[Finnur, 2013/10/04 17:57:02]

Added comments.

On 2013/10/03 22:08:50, Yoyo Zhou wrote:

+  };
+
   // Register prefs for keybinding.
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   // Constructs a CommandService object for the given profile.
   explicit CommandService(Profile* profile);
   virtual ~CommandService();
 
   // ProfileKeyedAPI implementation.
   static ProfileKeyedAPIFactory<CommandService>* GetFactoryInstance();
 
@@ skipping 29 matching lines @@
   // is ACTIVE_ONLY. |command| contains the command found and |active| (if not
   // NULL) contains whether |command| is active.
   bool GetScriptBadgeCommand(const std::string& extension_id,
                              QueryType type,
                              extensions::Command* command,
                              bool* active);
 
   // Gets the active command (if any) for the named commands of an extension
   // given its |extension_id|. The function consults the master list to see if
   // the command is active. Returns an empty map if the extension has no
-  // named commands or no active named commands when |type| requested is
-  // ACTIVE_ONLY.
+  // named commands of the right |scope| or no active named commands when |type|

[Yoyo Zhou, 2013/10/03 22:08:50]

..."no such active named commands"...?

[Finnur, 2013/10/04 17:57:02]

Done.

+  // requested is ACTIVE_ONLY.
   bool GetNamedCommands(const std::string& extension_id,
                         QueryType type,
+                        CommandScope scope,
                         extensions::CommandMap* command_map);
 
   // Records a keybinding |accelerator| as active for an extension with id
   // |extension_id| and command with the name |command_name|. If
   // |allow_overrides| is false, the keybinding must be free for the change to
   // be recorded (as determined by the master list in |user_prefs|). If
   // |allow_overwrites| is true, any previously recorded keybinding for this
   // |accelerator| will be overwritten. Returns true if the change was
   // successfully recorded.
   bool AddKeybindingPref(const ui::Accelerator& accelerator,
@@ skipping 60 matching lines @@
 
   // A weak pointer to the profile we are associated with. Not owned by us.
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(CommandService);
 };
 
 }  //  namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_COMMANDS_COMMAND_SERVICE_H_