Use sheetText() instead of decodedText() in the CSS preload scanner

Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331
Committed: https://crrev.com/86f86835d8d5c33a6fa40cf12511ee1f9d5337e5
Cr-Commit-Position: refs/heads/master@{#422505}

[Charlie Harrison, 2016-09-30 12:47:24]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 12:47:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-09-30 14:07:51]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 14:08:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-09-30 14:08:31]

Description was changed from

==========
Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

BUG=646869
==========

to

==========
Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331
==========

[Charlie Harrison, 2016-09-30 14:10:48]

csharrison@chromium.org changed reviewers:
+ japhet@chromium.org

[Charlie Harrison, 2016-09-30 14:10:49]

japhet@, would you PTAL at this fairly straightforward CL?

[commit-bot: I haz the power, 2016-09-30 15:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:15:59]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-09-30 23:08:51]

LGTM, but would you mind taking a quick look at whether we can make
TextResource::decodedText() protected?

[Charlie Harrison, 2016-10-03 03:38:56]

On 2016/09/30 23:08:51, Nate Chapin wrote:
> LGTM, but would you mind taking a quick look at whether we can make
> TextResource::decodedText() protected?

There is one more consumer, InspectorPageAgent that needs this method :/

[Charlie Harrison, 2016-10-03 03:40:02]

I could expose it off only ScriptResource if you want though.

[Charlie Harrison, 2016-10-03 16:32:39]

Think I'll just land this as-is, we can explore moving decodedText into
ScriptResource but there aren't huge complexity wins from that.

[Charlie Harrison, 2016-10-03 16:32:53]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-10-03 16:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2381193004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-03 16:33:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:07:34]

Description was changed from

==========
Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331
==========

to

==========
Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331
==========

[commit-bot: I haz the power, 2016-10-03 20:07:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-03 20:09:47]

Description was changed from

==========
Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331
==========

to

==========
Use sheetText() instead of decodedText() in the CSS preload scanner

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331

Committed: https://crrev.com/86f86835d8d5c33a6fa40cf12511ee1f9d5337e5
Cr-Commit-Position: refs/heads/master@{#422505}
==========

[commit-bot: I haz the power, 2016-10-03 20:09:49]

Patchset 3 (id:??) landed as
https://crrev.com/86f86835d8d5c33a6fa40cf12511ee1f9d5337e5
Cr-Commit-Position: refs/heads/master@{#422505}