Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2381113002: Reland [System Health] Create first System Health media user stories. (Closed)

Created:
4 years, 2 months ago by rnephew (Reviews Here)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland [System Health] Create first System Health media user stories. https://codereview.chromium.org/2334233002/ Audio cases for soundcloud and google play music. BUG=646392 Committed: https://crrev.com/a571e59f36e47b69542f3363b10f6129110f814b Cr-Commit-Position: refs/heads/master@{#421918}

Patch Set 1 #

Patch Set 2 : disable media tests in smoke tests #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -19 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/page_sets/data/credentials.json.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/data/system_health_desktop.json View 1 chunk +10 lines, -3 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_030.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_032.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/perf/page_sets/login_helpers/pandora_login.py View 1 chunk +8 lines, -15 lines 0 comments Download
A tools/perf/page_sets/system_health/media_stories.py View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
rnephew (Reviews Here)
Disabling them in the CQ. They are causing timeouts on retry. I want to see ...
4 years, 2 months ago (2016-09-29 19:15:50 UTC) #2
nednguyen
lgtm
4 years, 2 months ago (2016-09-29 19:20:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381113002/20001
4 years, 2 months ago (2016-09-29 19:21:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/77482) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-29 19:24:10 UTC) #7
rnephew (Reviews Here)
On 2016/09/29 19:24:10, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-09-29 19:30:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381113002/40001
4 years, 2 months ago (2016-09-29 19:31:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 20:21:10 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:23:27 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a571e59f36e47b69542f3363b10f6129110f814b
Cr-Commit-Position: refs/heads/master@{#421918}

Powered by Google App Engine
This is Rietveld 408576698