Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: src/ast.h

Issue 23811003: Initialize CompareOperation::combined_type to avoid crashes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2020 matching lines...) Expand 10 before | Expand all | Expand 10 after
2031 protected: 2031 protected:
2032 CompareOperation(Isolate* isolate, 2032 CompareOperation(Isolate* isolate,
2033 Token::Value op, 2033 Token::Value op,
2034 Expression* left, 2034 Expression* left,
2035 Expression* right, 2035 Expression* right,
2036 int pos) 2036 int pos)
2037 : Expression(isolate), 2037 : Expression(isolate),
2038 op_(op), 2038 op_(op),
2039 left_(left), 2039 left_(left),
2040 right_(right), 2040 right_(right),
2041 pos_(pos) { 2041 pos_(pos),
2042 combined_type_(Type::Null(), isolate) {
2042 ASSERT(Token::IsCompareOp(op)); 2043 ASSERT(Token::IsCompareOp(op));
2043 } 2044 }
2044 2045
2045 private: 2046 private:
2046 Token::Value op_; 2047 Token::Value op_;
2047 Expression* left_; 2048 Expression* left_;
2048 Expression* right_; 2049 Expression* right_;
2049 int pos_; 2050 int pos_;
2050 2051
2051 Handle<Type> combined_type_; 2052 Handle<Type> combined_type_;
(...skipping 1190 matching lines...) Expand 10 before | Expand all | Expand 10 after
3242 private: 3243 private:
3243 Isolate* isolate_; 3244 Isolate* isolate_;
3244 Zone* zone_; 3245 Zone* zone_;
3245 Visitor visitor_; 3246 Visitor visitor_;
3246 }; 3247 };
3247 3248
3248 3249
3249 } } // namespace v8::internal 3250 } } // namespace v8::internal
3250 3251
3251 #endif // V8_AST_H_ 3252 #endif // V8_AST_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698