Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2381063004: [Android] Add --unmap-all to forwarder2. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, sullivan, rnephew (Reviews Here)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add --unmap-all to forwarder2. In some scenarios (e.g., single-device restart), we want to unmap all ports forwarded from a given device up to the host and clear the existing cached adb port for that device. We want to be able to do this even if the calling process doesn't know all of those ports. This change adds the --unmap-all command to forwarder2 to support such use cases. BUG=634052, 650674 Committed: https://crrev.com/3d77e97fb46b4f0a9f9255c30b617abf6721ad33 Cr-Commit-Position: refs/heads/master@{#422113}

Patch Set 1 #

Total comments: 2

Patch Set 2 : agrieve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -45 lines) Patch
M tools/android/forwarder2/host_forwarder_main.cc View 1 11 chunks +120 lines, -45 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 2 months ago (2016-09-30 14:17:34 UTC) #2
agrieve
lgtm https://codereview.chromium.org/2381063004/diff/1/tools/android/forwarder2/host_forwarder_main.cc File tools/android/forwarder2/host_forwarder_main.cc (right): https://codereview.chromium.org/2381063004/diff/1/tools/android/forwarder2/host_forwarder_main.cc#newcode236 tools/android/forwarder2/host_forwarder_main.cc:236: LOG(INFO) << controller_key->first; intentional? If so, maybe prefix ...
4 years, 2 months ago (2016-09-30 14:41:07 UTC) #3
jbudorick
https://codereview.chromium.org/2381063004/diff/1/tools/android/forwarder2/host_forwarder_main.cc File tools/android/forwarder2/host_forwarder_main.cc (right): https://codereview.chromium.org/2381063004/diff/1/tools/android/forwarder2/host_forwarder_main.cc#newcode236 tools/android/forwarder2/host_forwarder_main.cc:236: LOG(INFO) << controller_key->first; On 2016/09/30 14:41:07, agrieve wrote: > ...
4 years, 2 months ago (2016-09-30 14:46:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381063004/20001
4 years, 2 months ago (2016-09-30 14:46:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 14:59:39 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 15:04:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d77e97fb46b4f0a9f9255c30b617abf6721ad33
Cr-Commit-Position: refs/heads/master@{#422113}

Powered by Google App Engine
This is Rietveld 408576698