Make showHide combinators work with getter/setter names

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 7636 matching lines @@
 }
 
 
 void Namespace::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->OpenObject();
   stream->CloseObject();
 }
 
 
 bool Namespace::HidesName(const String& name) const {
+  // Quick check for common case with no combinators.
+  if (hide_names() == show_names()) {
+    ASSERT(hide_names() == Array::null());
+    return false;
+  }
+  const String* plain_name = &name;
+  if (Field::IsGetterName(name)) {
+    plain_name = &String::Handle(Field::NameFromGetter(name));
+  } else if (Field::IsSetterName(name)) {
+    plain_name = &String::Handle(Field::NameFromSetter(name));
+  }
   // Check whether the name is in the list of explicitly hidden names.
   if (hide_names() != Array::null()) {
     const Array& names = Array::Handle(hide_names());
     String& hidden = String::Handle();
     intptr_t num_names = names.Length();
     for (intptr_t i = 0; i < num_names; i++) {
       hidden ^= names.At(i);
-      if (name.Equals(hidden)) {
+      if (plain_name->Equals(hidden)) {
         return true;
       }
     }
   }
   // The name is not explicitly hidden. Now check whether it is in the
   // list of explicitly visible names, if there is one.
   if (show_names() != Array::null()) {
     const Array& names = Array::Handle(show_names());
     String& shown = String::Handle();
     intptr_t num_names = names.Length();
     for (intptr_t i = 0; i < num_names; i++) {
       shown ^= names.At(i);
-      if (name.Equals(shown)) {
+      if (plain_name->Equals(shown)) {
         return false;
       }
     }
     // There is a list of visible names. The name we're looking for is not
     // contained in the list, so it is hidden.
     return true;
   }
   // The name is not filtered out.
   return false;
 }
@@ skipping 7213 matching lines @@
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->OpenObject();
   stream->CloseObject();
 }
 
 
 }  // namespace dart