Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2380993003: Readd default function variables upon scope reset for preparse abort (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Readd default function variables upon scope reset for preparse abort BUG=chromium:651327 Committed: https://crrev.com/fecd09ce32596c3fedf8cdf324f1314428752ff2 Cr-Commit-Position: refs/heads/master@{#39864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -7 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser-base.h View 2 chunks +2 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-651327.js View 1 chunk +217 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-09-29 12:45:09 UTC) #2
vogelheim
lgtm
4 years, 2 months ago (2016-09-29 12:55:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380993003/1
4 years, 2 months ago (2016-09-29 12:57:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 13:29:10 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 13:29:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fecd09ce32596c3fedf8cdf324f1314428752ff2
Cr-Commit-Position: refs/heads/master@{#39864}

Powered by Google App Engine
This is Rietveld 408576698