Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: src/arm64/code-stubs-arm64.cc

Issue 2380973002: [stubs] replaced ToString MacroAssembler Stub with CodeStubAssembler builtin (Closed)
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into ToStringTFStub Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/builtins/arm/builtins-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/code-stubs-arm64.cc
diff --git a/src/arm64/code-stubs-arm64.cc b/src/arm64/code-stubs-arm64.cc
index 1296360b2fc74dc88bf392d00356c63899c6c89b..5c34c3952b3a8c3c94f77b00d41a22be853b6fdd 100644
--- a/src/arm64/code-stubs-arm64.cc
+++ b/src/arm64/code-stubs-arm64.cc
@@ -2673,37 +2673,6 @@ void CompareICStub::GenerateMiss(MacroAssembler* masm) {
__ Jump(stub_entry);
}
-void ToStringStub::Generate(MacroAssembler* masm) {
- // The ToString stub takes one argument in x0.
- Label is_number;
- __ JumpIfSmi(x0, &is_number);
-
- Label not_string;
- __ JumpIfObjectType(x0, x1, x1, FIRST_NONSTRING_TYPE, &not_string, hs);
- // x0: receiver
- // x1: receiver instance type
- __ Ret();
- __ Bind(&not_string);
-
- Label not_heap_number;
- __ Cmp(x1, HEAP_NUMBER_TYPE);
- __ B(ne, &not_heap_number);
- __ Bind(&is_number);
- NumberToStringStub stub(isolate());
- __ TailCallStub(&stub);
- __ Bind(&not_heap_number);
-
- Label not_oddball;
- __ Cmp(x1, ODDBALL_TYPE);
- __ B(ne, &not_oddball);
- __ Ldr(x0, FieldMemOperand(x0, Oddball::kToStringOffset));
- __ Ret();
- __ Bind(&not_oddball);
-
- __ Push(x0); // Push argument.
- __ TailCallRuntime(Runtime::kToString);
-}
-
void StringHelper::GenerateFlatOneByteStringEquals(
MacroAssembler* masm, Register left, Register right, Register scratch1,
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/builtins/arm/builtins-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698