Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 2380973002: [stubs] replaced ToString MacroAssembler Stub with CodeStubAssembler builtin (Closed)
Patch Set: completely removed ToStringStub Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index 055d1293ee95bca6cc10e984b99cd32616c3c0e2..43411d44da64dffb4584cb3863591583ab48e9e3 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -7,6 +7,7 @@
#include <memory>
#include "src/bailout-reason.h"
+#include "src/code-factory.h"
#include "src/crankshaft/hydrogen.h"
#include "src/crankshaft/lithium.h"
#include "src/field-index.h"
@@ -1042,10 +1043,10 @@ HValue* CodeStubGraphBuilderBase::BuildToString(HValue* input, bool convert) {
}
if_inputisprimitive.End();
// Convert the primitive to a string value.
- ToStringStub stub(isolate());
HValue* values[] = {context(), Pop()};
- Push(AddUncasted<HCallWithDescriptor>(Add<HConstant>(stub.GetCode()), 0,
- stub.GetCallInterfaceDescriptor(),
+ Callable toString = CodeFactory::ToString(isolate());
+ Push(AddUncasted<HCallWithDescriptor>(Add<HConstant>(toString.code()), 0,
+ toString.descriptor(),
ArrayVector(values)));
}
if_inputisstring.End();

Powered by Google App Engine
This is Rietveld 408576698