Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2380943006: Notify the renderer if a history navigation has no subframe items. (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
4 years, 2 months ago
Reviewers:
alexmos, nasko
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Notify the renderer if a history navigation has no subframe items. In this case, the renderer does not need to consult the browser process if subframes are created during the navigation. Since there are no history items for it, the renderer can just load the default URL. BUG=638088, 639842 TEST=Restore chrome://settings after disabling MD settings mode. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2316003002 Cr-Commit-Position: refs/heads/master@{#420486} (cherry picked from commit 45b3bba45f5c1276726541db2f6f8ca6c5e05b65) Committed: https://chromium.googlesource.com/chromium/src/+/2c38c57dd850f83ba7d1a6713a0552175200efd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -6 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/navigation_params.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/common/navigation_params.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +11 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Charlie Reis
FYI: Merging to M54.
4 years, 2 months ago (2016-09-30 19:52:35 UTC) #2
Charlie Reis
Committed patchset #1 (id:1) manually as 2c38c57dd850f83ba7d1a6713a0552175200efd1.
4 years, 2 months ago (2016-09-30 19:57:52 UTC) #4
Charlie Reis
4 years, 2 months ago (2016-09-30 20:44:00 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2384833002/ by creis@chromium.org.

The reason for reverting is: Broke compile on M54..

Powered by Google App Engine
This is Rietveld 408576698