Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2380943003: Update automation scripts for wpt tests (Closed)

Created:
4 years, 2 months ago by Navid Zolghadr
Modified:
4 years, 2 months ago
Reviewers:
mustaq
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update automation scripts for wpt tests Update automation scripts for web platform pointer event tests to accomodate for reduce hit-testing. BUG=630671 Committed: https://crrev.com/95738af4ad7e5db7931216b75bd5202f02842f89 Cr-Commit-Position: refs/heads/master@{#421869}

Patch Set 1 #

Total comments: 3

Messages

Total messages: 14 (7 generated)
Navid Zolghadr
4 years, 2 months ago (2016-09-29 16:06:03 UTC) #4
mustaq
https://codereview.chromium.org/2380943003/diff/1/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js File third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js (right): https://codereview.chromium.org/2380943003/diff/1/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js#newcode7 third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js:7: return mouseDragInTargets(['#btnCapture', '#btnCapture', '#target1', '#target0', '#target1']); Why two #btnCapture ...
4 years, 2 months ago (2016-09-29 17:47:19 UTC) #7
Navid Zolghadr
https://codereview.chromium.org/2380943003/diff/1/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js File third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js (right): https://codereview.chromium.org/2380943003/diff/1/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js#newcode7 third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js:7: return mouseDragInTargets(['#btnCapture', '#btnCapture', '#target1', '#target0', '#target1']); On 2016/09/29 17:47:18, ...
4 years, 2 months ago (2016-09-29 17:48:59 UTC) #8
mustaq
lgtm https://codereview.chromium.org/2380943003/diff/1/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js File third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js (right): https://codereview.chromium.org/2380943003/diff/1/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js#newcode7 third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js:7: return mouseDragInTargets(['#btnCapture', '#btnCapture', '#target1', '#target0', '#target1']); On 2016/09/29 ...
4 years, 2 months ago (2016-09-29 17:56:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380943003/1
4 years, 2 months ago (2016-09-29 17:58:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 18:05:08 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 18:07:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95738af4ad7e5db7931216b75bd5202f02842f89
Cr-Commit-Position: refs/heads/master@{#421869}

Powered by Google App Engine
This is Rietveld 408576698