Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(199)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/navigation_controller/dynamic_iframe.html
Issue
2380943002
:
Tell renderer which subframes have history items on back/forward. (Closed)
Patch Set: Add test
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/browser/frame_host/navigation_controller_impl_browsertest.cc
content/browser/frame_host/navigation_entry_impl.h
content/browser/frame_host/navigation_entry_impl.cc
content/browser/frame_host/navigation_request.cc
content/browser/frame_host/navigator_impl.cc
content/common/frame_messages.h
content/common/navigation_params.h
content/common/navigation_params.cc
content/renderer/render_frame_impl.h
content/renderer/render_frame_impl.cc
content/test/data/navigation_controller/dynamic_iframe.html
View unified diff
|
Download patch
« content/renderer/render_frame_impl.cc
('K') |
« content/renderer/render_frame_impl.cc
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<head></head>
3
<body>
4
<p>This page creates an iframe with dynamic name and content.</p>
5
<script>
6
var now = Date.now();
7
var f = document.createElement("iframe");
8
f.name = now;
9
document.body.appendChild(f);
10
f.src = "data:text/html,Date: " + now;
11
</script>
12
</body>
13
</html>
OLD
NEW
« content/renderer/render_frame_impl.cc
('K') |
« content/renderer/render_frame_impl.cc
('k') |
no next file »
|
no next file with comments »
Issue 2380943002: Tell renderer which subframes have history items on back/forward. (Closed)
Created 4 years, 2 months ago by Charlie Reis
Modified 4 years, 2 months ago
Reviewers: alexmos, dcheng
Base URL:
Comments: 13
This is Rietveld
408576698
Chromium Code Reviews
Issue 2380943002:
Tell renderer which subframes have history items on back/forward. (Closed)
