Tell renderer which subframes have history items on back/forward.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 3023 matching lines @@
   EXPECT_EQ(1, controller.GetLastCommittedEntryIndex());
   EXPECT_EQ(entry2, controller.GetLastCommittedEntry());
 
   // The entry should have both the stale FrameNavigationEntry with the old
   // name and the new FrameNavigationEntry for the fallback navigation.
   ASSERT_EQ(2U, entry2->root_node()->children.size());
   EXPECT_EQ(frame_url_b, entry2->root_node()->children[0]->frame_entry->url());
   EXPECT_EQ(data_url, entry2->root_node()->children[1]->frame_entry->url());
 }
 
+// Allows waiting until an URL with a data scheme commits in any frame.
+class DataUrlCommitObserver : public WebContentsObserver {
+ public:
+  explicit DataUrlCommitObserver(WebContents* web_contents)
+      : WebContentsObserver(web_contents),
+        message_loop_runner_(new MessageLoopRunner) {}
+
+  void Wait() { message_loop_runner_->Run(); }
+
+ private:
+  void DidFinishNavigation(NavigationHandle* navigation_handle) override {
+    if (navigation_handle->HasCommitted() &&
+        !navigation_handle->IsErrorPage() &&
+        navigation_handle->GetURL().scheme() == "data")
+      message_loop_runner_->Quit();
+  }
+
+  // The MessageLoopRunner used to spin the message loop.
+  scoped_refptr<MessageLoopRunner> message_loop_runner_;
+};
+
+// Verify that dynamically generated iframes load properly during a history
+// navigation if no history item can be found for them.
+// See https://crbug.com/649345.
+IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
+                       FrameNavigationEntry_DynamicSubframeHistoryFallback) {
+  // This test only makes sense when subframe FrameNavigationEntries are in use.
+  if (!SiteIsolationPolicy::UseSubframeNavigationEntries())
+    return;
+
+  // 1. Start on a page with a script-generated iframe.  The iframe has a
+  // dynamic name, starts at about:blank, and gets navigated to a dynamic data
+  // URL as the page is loading.
+  GURL main_url_a(embedded_test_server()->GetURL(
+      "a.com", "/navigation_controller/dynamic_iframe.html"));
+  {
+    // Wait until the data URL has committed, even if load stop happens after
+    // about:blank load.
+    DataUrlCommitObserver data_observer(shell()->web_contents());
+    NavigateToURL(shell(), main_url_a);

[alexmos, 2016/09/29 21:55:53]

nit: EXPECT_TRUE, also below

[Charlie Reis, 2016/09/29 22:22:48]

D'oh!  Done.  One day I'll fix the rest of the occurrences in this file so I
stop copy/pasting them.  :)

+    data_observer.Wait();
+  }
+  const NavigationControllerImpl& controller =
+      static_cast<const NavigationControllerImpl&>(
+          shell()->web_contents()->GetController());
+  FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
+                            ->GetFrameTree()
+                            ->root();
+  ASSERT_EQ(1U, root->child_count());
+  ASSERT_EQ(0U, root->child_at(0)->child_count());
+  EXPECT_EQ(main_url_a, root->current_url());
+  EXPECT_EQ("data", root->child_at(0)->current_url().scheme());
+
+  EXPECT_EQ(1, controller.GetEntryCount());
+  EXPECT_EQ(0, controller.GetLastCommittedEntryIndex());
+  NavigationEntryImpl* entry1 = controller.GetLastCommittedEntry();
+
+  // The entry should have a FrameNavigationEntry for the data subframe.
+  ASSERT_EQ(1U, entry1->root_node()->children.size());
+  EXPECT_EQ("data",
+            entry1->root_node()->children[0]->frame_entry->url().scheme());
+
+  // 2. Navigate main frame cross-site, destroying the frames.
+  GURL main_url_b(embedded_test_server()->GetURL(
+      "b.com", "/navigation_controller/simple_page_2.html"));
+  NavigateToURL(shell(), main_url_b);
+  ASSERT_EQ(0U, root->child_count());
+  EXPECT_EQ(main_url_b, root->current_url());
+
+  EXPECT_EQ(2, controller.GetEntryCount());
+  EXPECT_EQ(1, controller.GetLastCommittedEntryIndex());
+  NavigationEntryImpl* entry2 = controller.GetLastCommittedEntry();
+  EXPECT_EQ(0U, entry2->root_node()->children.size());
+
+  // Force the subframe entry to have the wrong name, so that it isn't found
+  // when we go back.  (The page should give it a different name anyway, but
+  // this safeguards against flakiness.)

[alexmos, 2016/09/29 21:55:53]

Wow, I'm curious how the flakiness could possibly occur.  Was the resolution of
Date.now() not enough so that it was actually giving it the same name as before?
 performance.now() might be less prone to that.

[Charlie Reis, 2016/09/29 22:22:48]

It wasn't actually failing for me, but I was trying to eliminate other sources
of flakiness as I investigated it.  I agree that performance.now does seem to be
even less likely to flake here, so I've removed this line.

+  entry1->root_node()->children[0]->frame_entry->set_frame_unique_name("wrong");
+
+  // 3. Go back, recreating the iframe.  The subframe will have a new name this
+  // time, so we won't find a history item for it.  We should let the new data
+  // URL be loaded into it, rather than clobbering it with an about:blank page.
+  {
+    // Wait until the data URL has committed, even if load stop happens first.
+    DataUrlCommitObserver back_load_observer(shell()->web_contents());
+    shell()->web_contents()->GetController().GoBack();
+    back_load_observer.Wait();
+  }
+  EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
+  ASSERT_EQ(1U, root->child_count());
+  EXPECT_EQ(main_url_a, root->current_url());
+  EXPECT_EQ("data", root->child_at(0)->current_url().scheme());
+
+  EXPECT_EQ(2, controller.GetEntryCount());
+  EXPECT_EQ(0, controller.GetLastCommittedEntryIndex());
+  EXPECT_EQ(entry1, controller.GetLastCommittedEntry());
+
+  // The entry should have both the stale FrameNavigationEntry with the old
+  // name and the new FrameNavigationEntry for the fallback navigation.

[alexmos, 2016/09/29 21:55:53]

Just curious, why do we need to keep the stale FrameNavigationEntry around?

[Charlie Reis, 2016/09/29 22:22:48]

In general, we don't remove subframe history items when frames are removed from
the page.  That way frames can be restored if they get deleted by some JS action
and then you leave and come back.

In this case, I suppose it's possible we could clear out any unused FNEs when
going back at DidStopLoading, but we don't really track which ones were used
during the navigation.  Plus it could be there if you leave and come back again
(in case the page was just broken for a bit).

Anyway, seems in line with the frame removal case, so I think it's safe to leave
as is.

+  ASSERT_EQ(2U, entry1->root_node()->children.size());
+  EXPECT_EQ("data",
+            entry1->root_node()->children[0]->frame_entry->url().scheme());
+  EXPECT_EQ("data",
+            entry1->root_node()->children[1]->frame_entry->url().scheme());

[alexmos, 2016/09/29 21:55:53]

Not that it matters, but you could also double-check that the frame_unique_name
is not equal to "wrong" at this point.

[Charlie Reis, 2016/09/29 22:22:48]

I'll stick with the scheme check, now that I've removed the "wrong" name.

+
+  // The iframe commit should have been classified AUTO_SUBFRAME and not
+  // NEW_SUBFRAME, so we should still be able to go forward.
+  EXPECT_TRUE(shell()->web_contents()->GetController().CanGoForward());
+}
+
 // Verify that we don't clobber any content injected into the initial blank page
 // if we go back to an about:blank subframe.  See https://crbug.com/626416.
 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
                        FrameNavigationEntry_RecreatedBlankSubframe) {
   // 1. Start on a page that injects content into an about:blank iframe.
   GURL main_url(embedded_test_server()->GetURL(
       "/navigation_controller/inject_into_blank_iframe.html"));
   GURL blank_url(url::kAboutBlankURL);
   EXPECT_TRUE(NavigateToURL(shell(), main_url));
   NavigationControllerImpl& controller = static_cast<NavigationControllerImpl&>(
@@ skipping 3174 matching lines @@
 
   // What happens now is that attempting to unload the first page will trigger a
   // JavaScript alert but allow navigation. The alert IPC will be suspended by
   // the message filter. The commit of the second page will unblock the IPC. If
   // the dialog IPC is allowed to spawn a dialog, the call by the WebContents to
   // its delegate to get the JavaScriptDialogManager will cause a CHECK and the
   // test will fail.
 }
 
 }  // namespace content