Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2380933004: Update layout documentation re: coordinate systems and writing mode. (Closed)
Patch Set: Sync to head. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/README.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.
5 * Copyright (C) 2010 Google Inc. All rights reserved. 5 * Copyright (C) 2010 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // ------------------------------------- v 121 // ------------------------------------- v
122 // 122 //
123 // 'bottom' / 'end' side 123 // 'bottom' / 'end' side
124 // 124 //
125 // See https://drafts.csswg.org/css-writing-modes-3/#text-flow for some 125 // See https://drafts.csswg.org/css-writing-modes-3/#text-flow for some
126 // extra details. 126 // extra details.
127 // 127 //
128 // - physical coordinates with flipped block-flow direction: those are physical 128 // - physical coordinates with flipped block-flow direction: those are physical
129 // coordinates but we flipped the block direction. See 129 // coordinates but we flipped the block direction. See
130 // LayoutBox::noOverflowRect. 130 // LayoutBox::noOverflowRect.
131 // TODO(jchaffraix): I don't fully understand why we need this coordinate 131 //
132 // system someone should fill in those details. 132 // For more, see Source/core/layout/README.md ### Coordinate Spaces.
133 class CORE_EXPORT LayoutBoxModelObject : public LayoutObject { 133 class CORE_EXPORT LayoutBoxModelObject : public LayoutObject {
134 public: 134 public:
135 LayoutBoxModelObject(ContainerNode*); 135 LayoutBoxModelObject(ContainerNode*);
136 ~LayoutBoxModelObject() override; 136 ~LayoutBoxModelObject() override;
137 137
138 // This is the only way layers should ever be destroyed. 138 // This is the only way layers should ever be destroyed.
139 void destroyLayer(); 139 void destroyLayer();
140 140
141 LayoutSize relativePositionOffset() const; 141 LayoutSize relativePositionOffset() const;
142 LayoutSize relativePositionLogicalOffset() const { 142 LayoutSize relativePositionLogicalOffset() const {
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 std::unique_ptr<PaintLayer> m_layer; 506 std::unique_ptr<PaintLayer> m_layer;
507 507
508 std::unique_ptr<LayoutBoxModelObjectRareData> m_rareData; 508 std::unique_ptr<LayoutBoxModelObjectRareData> m_rareData;
509 }; 509 };
510 510
511 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject()); 511 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());
512 512
513 } // namespace blink 513 } // namespace blink
514 514
515 #endif // LayoutBoxModelObject_h 515 #endif // LayoutBoxModelObject_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698