Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2380933004: Update layout documentation re: coordinate systems and writing mode. (Closed)
Patch Set: Restore class header comment. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.
5 * Copyright (C) 2010 Google Inc. All rights reserved. 5 * Copyright (C) 2010 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 // ------------------------------------- v 120 // ------------------------------------- v
121 // 121 //
122 // 'bottom' / 'end' side 122 // 'bottom' / 'end' side
123 // 123 //
124 // See https://drafts.csswg.org/css-writing-modes-3/#text-flow for some 124 // See https://drafts.csswg.org/css-writing-modes-3/#text-flow for some
125 // extra details. 125 // extra details.
126 // 126 //
127 // - physical coordinates with flipped block-flow direction: those are physical 127 // - physical coordinates with flipped block-flow direction: those are physical
128 // coordinates but we flipped the block direction. See 128 // coordinates but we flipped the block direction. See
129 // LayoutBox::noOverflowRect. 129 // LayoutBox::noOverflowRect.
130 // TODO(jchaffraix): I don't fully understand why we need this coordinate 130 //
131 // system someone should fill in those details. 131 // For more, see Source/core/layout/README.md ### Coordinate Spaces.
132 class CORE_EXPORT LayoutBoxModelObject : public LayoutObject { 132 class CORE_EXPORT LayoutBoxModelObject : public LayoutObject {
133 public: 133 public:
134 LayoutBoxModelObject(ContainerNode*); 134 LayoutBoxModelObject(ContainerNode*);
135 ~LayoutBoxModelObject() override; 135 ~LayoutBoxModelObject() override;
136 136
137 // This is the only way layers should ever be destroyed. 137 // This is the only way layers should ever be destroyed.
138 void destroyLayer(); 138 void destroyLayer();
139 139
140 LayoutSize relativePositionOffset() const; 140 LayoutSize relativePositionOffset() const;
141 LayoutSize relativePositionLogicalOffset() const { return style()->isHorizon talWritingMode() ? relativePositionOffset() : relativePositionOffset().transpose dSize(); } 141 LayoutSize relativePositionLogicalOffset() const { return style()->isHorizon talWritingMode() ? relativePositionOffset() : relativePositionOffset().transpose dSize(); }
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 std::unique_ptr<PaintLayer> m_layer; 380 std::unique_ptr<PaintLayer> m_layer;
381 381
382 std::unique_ptr<LayoutBoxModelObjectRareData> m_rareData; 382 std::unique_ptr<LayoutBoxModelObjectRareData> m_rareData;
383 }; 383 };
384 384
385 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject()); 385 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());
386 386
387 } // namespace blink 387 } // namespace blink
388 388
389 #endif // LayoutBoxModelObject_h 389 #endif // LayoutBoxModelObject_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/README.md » ('j') | third_party/WebKit/Source/core/layout/README.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698