Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: sync/engine/commit.cc

Issue 23809005: sync: Implement per-type GetCommitIds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Tim's comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/engine/get_commit_ids.h » ('j') | sync/engine/get_commit_ids.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/commit.cc
diff --git a/sync/engine/commit.cc b/sync/engine/commit.cc
index f7f1e74d99e0789eeeef0771ae7c23e5d2137a07..85e5f949d38270e116c211c619a396087bad4e86 100644
--- a/sync/engine/commit.cc
+++ b/sync/engine/commit.cc
@@ -6,8 +6,9 @@
#include "base/debug/trace_event.h"
#include "sync/engine/build_commit_command.h"
-#include "sync/engine/get_commit_ids_command.h"
+#include "sync/engine/get_commit_ids.h"
#include "sync/engine/process_commit_response_command.h"
+#include "sync/engine/syncer.h"
#include "sync/engine/syncer_proto_util.h"
#include "sync/sessions/sync_session.h"
#include "sync/syncable/mutable_entry.h"
@@ -76,11 +77,7 @@ bool PrepareCommitMessage(
// Fetch the items to commit.
const size_t batch_size = session->context()->max_commit_batch_size();
- GetCommitIdsCommand get_commit_ids_command(&trans,
- requested_types,
- batch_size,
- commit_set);
- get_commit_ids_command.Execute(session);
+ GetCommitIds(&trans, requested_types, batch_size, commit_set);
DVLOG(1) << "Commit message will contain " << commit_set->Size() << " items.";
if (commit_set->Empty()) {
« no previous file with comments | « no previous file | sync/engine/get_commit_ids.h » ('j') | sync/engine/get_commit_ids.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698