Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2380863003: fix #27135 and fix #27449 strong mode does not use propagated types (Closed)

Created:
4 years, 2 months ago by Jennifer Messerly
Modified:
4 years, 2 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27135 and fix #27449 strong mode does not use propagated types R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/5c9e12497ec7d168bcd2b1cb602a931457fd7be2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -34 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 4 chunks +8 lines, -16 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 2 months ago (2016-09-29 01:16:41 UTC) #2
Leaf
lgtm
4 years, 2 months ago (2016-09-29 05:12:12 UTC) #3
Jennifer Messerly
4 years, 2 months ago (2016-09-29 07:14:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c9e12497ec7d168bcd2b1cb602a931457fd7be2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698