Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2380853002: Fixed minor error in IncrementalMarking::AdvanceIncrementalMarkingOnAllocation (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed minor error in IncrementalMarking::AdvanceIncrementalMarkingOnAllocation bytes_processed should be used instead of bytes_to_process when updating bytes_allocated_. Also updated the type of bytes_processed since min() takes in 2 variables of the same type. The code was added as part of: https://codereview.chromium.org/2359903002 R=hpayer@chromium.org,ulan@chromium.org BUG= Committed: https://crrev.com/1fb4498c405a773399451919ac1b1905caba37a7 Cr-Commit-Position: refs/heads/master@{#39857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/heap/incremental-marking.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-09-28 20:36:19 UTC) #1
ulan
LGTM, thank you for fixing!
4 years, 2 months ago (2016-09-29 09:49:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380853002/1
4 years, 2 months ago (2016-09-29 09:49:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 10:22:32 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 10:22:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fb4498c405a773399451919ac1b1905caba37a7
Cr-Commit-Position: refs/heads/master@{#39857}

Powered by Google App Engine
This is Rietveld 408576698