Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2380833002: Make applyCropRect/pad_image convert to the output color space (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make applyCropRect/pad_image convert to the output color space The source's color space may not be renderable, leading to makeSurface failing. This is unfortunate, but this solution is by far the simplest. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2380833002 Committed: https://skia.googlesource.com/skia/+/79523901c9f5c753b515349748ea8fa3a32e793d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/core/SkImageFilter.cpp View 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Brian Osman
This fixes some failures that popped up in the displacement GM on bots without sRGB ...
4 years, 2 months ago (2016-09-28 19:09:20 UTC) #5
robertphillips
lgtm :(
4 years, 2 months ago (2016-09-28 19:56:52 UTC) #8
bsalomon
+1 (code review not commit)
4 years, 2 months ago (2016-09-28 20:00:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380833002/1
4 years, 2 months ago (2016-09-28 20:01:51 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:03:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/79523901c9f5c753b515349748ea8fa3a32e793d

Powered by Google App Engine
This is Rietveld 408576698