[CSS Shapes] Properly shrink boxes to avoid shape-outside

[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;.

BUG=427989
Committed: https://crrev.com/67aa2c210c705c00eef054c71d3e88b930d08124
Cr-Commit-Position: refs/heads/master@{#422782}

[rwlbuis, 2016-09-28 22:30:47]

Description was changed from

==========
427989 WIP

BUG=
==========

to

==========
427989 WIP

BUG=427989
==========

[rwlbuis, 2016-09-28 22:32:48]

Description was changed from

==========
427989 WIP

BUG=427989
==========

to

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;.


BUG=427989
==========

[rwlbuis, 2016-09-28 22:33:02]

Description was changed from

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;.


BUG=427989
==========

to

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;.

BUG=427989
==========

[rwlbuis, 2016-09-28 22:33:53]

Description was changed from

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>;.

BUG=427989
==========

to

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>.

BUG=427989
==========

[rwlbuis, 2016-09-28 22:36:20]

rob.buis@samsung.com changed reviewers:
+ eae@chromium.org

[rwlbuis, 2016-09-28 22:36:21]

PTAL.

[eae, 2016-09-29 16:04:34]

LGTM

[rwlbuis, 2016-09-29 17:02:20]

On 2016/09/29 16:04:34, eae wrote:
> LGTM

Thanks, however see the bug, I think it needs more work, will have another go
next week.

[rwlbuis, 2016-10-03 21:10:51]

Patchset #3 (id:40001) has been deleted

[rwlbuis, 2016-10-03 21:31:53]

On 2016/09/29 17:02:20, rwlbuis wrote:
> On 2016/09/29 16:04:34, eae wrote:
> > LGTM
> 
> Thanks, however see the bug, I think it needs more work, will have another go
> next week.

Okay, the plot thickens, the minimized testcase renders exactly the same in
Firefox nightly, my WebKitGTK build and blink! All render the text above the
blue box which is not supposed to happen according to the text, so maybe the
testcase is bad.

Given above, I think it may be worth a shot to commit this after all and see if
anything breaks, let me know.

[eae, 2016-10-03 21:42:54]

Ok, thanks for the update!

[rwlbuis, 2016-10-03 23:34:03]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-10-03 23:34:03]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2380813002/#ps80001
(title: "Upload right version of patch")

[commit-bot: I haz the power, 2016-10-03 23:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 23:49:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-10-04 12:30:45]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-10-04 12:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 12:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 12:39:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rwlbuis, 2016-10-04 12:46:17]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-10-04 12:46:18]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2380813002/#ps100001
(title: "Reformat")

[commit-bot: I haz the power, 2016-10-04 12:46:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 14:16:37]

Description was changed from

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>.

BUG=427989
==========

to

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>.

BUG=427989
==========

[commit-bot: I haz the power, 2016-10-04 14:16:39]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-04 14:20:02]

Description was changed from

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>.

BUG=427989
==========

to

==========
[CSS Shapes] Properly shrink boxes to avoid shape-outside

To determine how much an box needs to shink to avoid a float, the code
was only taking into account the first line of the box. This doesn't
work when the float has a shape, as it can make it seem like there is
more space on the line than there actually is. This patch changes the
calculations to take into account the entire height of the box that
needs to be shrunk, and thus computes the correct amount of space
available.

This is a merge of http://trac.webkit.org/changeset/178045 and
http://trac.webkit.org/changeset/178064 by Bem Jones-Bey <bjonesbe@adobe.com>.

BUG=427989

Committed: https://crrev.com/67aa2c210c705c00eef054c71d3e88b930d08124
Cr-Commit-Position: refs/heads/master@{#422782}
==========

[commit-bot: I haz the power, 2016-10-04 14:20:04]

Patchset 5 (id:??) landed as
https://crrev.com/67aa2c210c705c00eef054c71d3e88b930d08124
Cr-Commit-Position: refs/heads/master@{#422782}