Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23808004: Revert 221197 "Adds an integration test for uninstalling app lis..." (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221197 "Adds an integration test for uninstalling app lis..." Breaks win aura builder. > Adds an integration test for uninstalling app list search results. > > This involves exposing the app list model to a BrowserTest, and ensuring > that changes in the model are properly observed by the UI. > > BUG=277897, 169114 > TEST=AppListControllerSearchResultsBrowserTest.UninstallSearchResult > > Review URL: https://chromiumcodereview.appspot.com/23072036 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -645 lines) Patch
M trunk/src/ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/ash/test/app_list_controller_test_api.h View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/ash/test/app_list_controller_test_api.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M trunk/src/ash/test/shell_test_api.h View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/ash/test/shell_test_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/ash/wm/app_list_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 2 chunks +0 lines, -140 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/app_list_service_mac.h View 1 chunk +0 lines, -69 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/app_list_service_mac.mm View 6 chunks +179 lines, -136 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/app_list_service_win.h View 1 chunk +1 line, -18 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/test/app_list_service_test_api.h View 1 chunk +0 lines, -35 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/test/app_list_service_test_api_ash.h View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/test/app_list_service_test_api_ash.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/test/app_list_service_test_api_mac.mm View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/chrome/browser/ui/app_list/test/app_list_service_test_api_win.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/app_list/app_list_controller_win.cc View 5 chunks +1 line, -16 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/ui/app_list/cocoa/apps_search_box_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/app_list/cocoa/apps_search_box_controller_unittest.mm View 1 chunk +5 lines, -7 lines 0 comments Download
M trunk/src/ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ui/app_list/views/search_box_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-04 17:03:32 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-04 17:03:58 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r221207.

Powered by Google App Engine
This is Rietveld 408576698