Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2380783002: Removing iOS from Multi-device docs (Closed)

Created:
4 years, 2 months ago by mkearney1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This removes all iOS content from Multi-device docs. We've tested the navigation locally both top and left-navs and it looks OK. BUG=605237 Committed: https://crrev.com/f7688a27d87e6cd98e8f5c91916010e81a67b715 Cr-Commit-Position: refs/heads/master@{#421623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mkearney1
Mike, I've copied you here for review, as we'll need an lgtm from a committer ...
4 years, 2 months ago (2016-09-28 18:40:24 UTC) #3
pink (ping after 24hrs)
lgtm
4 years, 2 months ago (2016-09-28 19:44:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380783002/1
4 years, 2 months ago (2016-09-28 20:07:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:16:52 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:19:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7688a27d87e6cd98e8f5c91916010e81a67b715
Cr-Commit-Position: refs/heads/master@{#421623}

Powered by Google App Engine
This is Rietveld 408576698