Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2380773002: Prevent tracking metrics for cases such as 204s and downloads. (Closed)
Patch Set: use existing test file Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 3c00e4a10afac5959e7ad7e89b67801980ffcf6d..e4c47cdc0c32d4f0074888a802a81d1d5542bee4 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -156,10 +156,9 @@ class CONTENT_EXPORT NavigationHandle {
// GetNetErrorCode will be net::OK.
virtual bool IsErrorPage() = 0;
- // Returns the response headers for the request or nullptr if there are none.
- // This should only be accessed after a redirect was encountered or after the
- // navigation is ready to commit. The headers returned should not be modified,
- // as modifications will not be reflected in the network stack.
+ // Returns the response headers for the request or nullptr if there are
clamy 2016/09/29 15:35:57 Please mention that these are the final headers. w
Bryan McQuade 2016/09/29 19:44:16 Done, thanks!
+ // none. The headers returned should not be modified, as modifications will
clamy 2016/09/29 15:35:57 nit: none or they have not been received yet.
Bryan McQuade 2016/09/29 19:44:16 Done.
+ // not be reflected in the network stack.
virtual const net::HttpResponseHeaders* GetResponseHeaders() = 0;
// Resumes a navigation that was previously deferred by a NavigationThrottle.
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698