Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2414)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2380753004: [CUPS] Implement the Webui handler for the printers auto discovery. (Closed)
Patch Set: Address michaelpg@'s comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
index 6be2a3e0244cb92926062738208dedbef2cef349..f594c188c29086f42e5b5f34c25f71cf66b049be 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
@@ -12,8 +12,31 @@
<template>
<style include="settings-shared">
add-printer-list {
- max-height: 350px;
+ max-height: 310px;
overflow-y: auto;
+ position: absolute;
+ width: 100%;
+ }
+
+ .dialog-body .center {
+ display: flex;
+ justify-content: center;
+ position: absolute;
+ top: 50%;
+ width: 100%;
+ }
+
+ #searchSpinner {
+ position: absolute;
+ top: 80%;
+ }
+
+ #searchSpinner paper-spinner {
+ --paper-spinner-stroke-width: 2px;
+ -webkit-margin-end: 3px;
+ -webkit-margin-start: 20px;
+ height: 15px;
+ width: 15px;
}
#manuallyAddPrinterButton {
@@ -25,7 +48,13 @@
<add-printer-list printers="[[discoveredPrinters]]"
selected-printer="{{selectedPrinter}}">
</add-printer-list>
- <!-- TODO(xdai): Add the paper-spinner -->
+ <div class="center" id="noPrinterMessage" hidden>
+ $i18n{noPrinterNearbyMessage}
+ </div>
+ <div id="searchSpinner" hidden="[[!discovering_]]">
+ <paper-spinner active="[[discovering_]]"></paper-spinner>
+ <span>$i18n{searchingNearbyPrinters}</span>
+ </div>
</div>
<div class="dialog-buttons">
<paper-button id="manuallyAddPrinterButton"
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698